Removed trafficAnalytics flag from apps/

9larsons · 9larsons · commit 99aa58005505 · 2025-07-16T16:26:48.000-05:00
ref https://linear.app/ghost/issue/PROD-2321/ - removed the trafficAnalytics flag and behavior from Settings - updated readme in stats app
diff --git a/apps/admin-x-settings/src/components/settings/advanced/labs/PrivateFeatures.tsx b/apps/admin-x-settings/src/components/settings/advanced/labs/PrivateFeatures.tsx
@@ -15,10 +15,6 @@ const features: Feature[] = [{
     title: 'Stripe Automatic Tax (private beta)',
     description: 'Use Stripe Automatic Tax at Stripe Checkout. Needs to be enabled in Stripe',
     flag: 'stripeAutomaticTax'
-}, {
-    title: 'Traffic Analytics (private beta)',
-    description: 'Enables traffic analytics',
-    flag: 'trafficAnalytics'
 }, {
     title: 'Email customization (internal beta)',
     description: 'Newsletter customization settings that have been released to Ghost\'s own production sites',
diff --git a/apps/admin-x-settings/src/components/settings/membership/Analytics.tsx b/apps/admin-x-settings/src/components/settings/membership/Analytics.tsx
@@ -1,6 +1,5 @@
 import React, {useEffect, useState} from 'react';
 import TopLevelGroup from '../../TopLevelGroup';
-import useFeatureFlag from '../../../hooks/useFeatureFlag';
 import useSettingGroup from '../../../hooks/useSettingGroup';
 import {HostLimitError, useLimiter} from '../../../hooks/useLimiter';
 import {Separator, SettingGroupContent, Toggle, withErrorBoundary} from '@tryghost/admin-x-design-system';
@@ -21,7 +20,6 @@ const Analytics: React.FC<{ keywords: string[] }> = ({keywords}) => {
     const [trackEmailOpens, trackEmailClicks, trackMemberSources, outboundLinkTagging, isWebAnalyticsConfigured, isWebAnalyticsEnabled] = getSettingValues(localSettings, [
         'email_track_opens', 'email_track_clicks', 'members_track_sources', 'outbound_link_tagging', 'web_analytics_configured', 'web_analytics_enabled'
     ]) as boolean[];
-    const taBetaFlagEnabled = useFeatureFlag('trafficAnalytics');
     const isEmailTrackClicksReadOnly = isSettingReadOnly(localSettings, 'email_track_clicks');
 
     const [isWebAnalyticsLimited, setIsWebAnalyticsLimited] = useState(false);
@@ -45,42 +43,38 @@ const Analytics: React.FC<{ keywords: string[] }> = ({keywords}) => {
 
     const inputs = (
         <SettingGroupContent className="analytics-settings !gap-y-0" columns={1}>
-            {taBetaFlagEnabled && (
-                <>
-                    <Toggle
-                        checked={isWebAnalyticsEnabled}
-                        direction='rtl'
-                        disabled={!isWebAnalyticsConfigured || isWebAnalyticsLimited}
-                        gap='gap-0'
-                        hint='Cookie-free, first party traffic analytics for your site'
-                        label='Web analytics'
-                        labelClasses='py-4 w-full'
-                        onChange={(e) => {
-                            handleToggleChange('web_analytics', e);
-                        }}
-                    />
-                    {(
-                        isWebAnalyticsLimited ? (
-                            <div className='mb-5 rounded-md border border-grey-200 bg-grey-50 px-4 py-2.5 text-sm dark:border-grey-900 dark:bg-grey-925'>
-                                <span className='flex items-start gap-2'>
-                                    <span>
-                                    Web analytics is available on the Publisher plan and above. <span className='text-green underline' onClick={() => updateRoute({route: '/pro', isExternal: true})}>Upgrade now &rarr;</span>
-                                    </span>
-                                </span>
-                            </div>
-                        ) : !isWebAnalyticsConfigured ? (
-                            <div className='mb-5 rounded-md border border-grey-200 bg-grey-50 px-4 py-2.5 text-sm dark:border-grey-900 dark:bg-grey-925'>
-                                <span className='flex items-start gap-2'>
-                                    <span>
-                                        Web analytics in Ghost is powered by <a className='text-green underline' href="https://tinybird.co" rel="noopener noreferrer" target='_blank'>Tinybird</a> and requires configuration to start collecting data. <a className='text-green underline' href="https://ghost.org/docs/" rel="noopener noreferrer" target='_blank'>Get started &rarr;</a>
-                                    </span>
-                                </span>
-                            </div>
-                        ) : (
-                            <Separator className="border-grey-200 dark:border-grey-900" />
-                        )
-                    )}
-                </>
+            <Toggle
+                checked={isWebAnalyticsEnabled}
+                direction='rtl'
+                disabled={!isWebAnalyticsConfigured || isWebAnalyticsLimited}
+                gap='gap-0'
+                hint='Cookie-free, first party traffic analytics for your site'
+                label='Web analytics'
+                labelClasses='py-4 w-full'
+                onChange={(e) => {
+                    handleToggleChange('web_analytics', e);
+                }}
+            />
+            {(
+                isWebAnalyticsLimited ? (
+                    <div className='mb-5 rounded-md border border-grey-200 bg-grey-50 px-4 py-2.5 text-sm dark:border-grey-900 dark:bg-grey-925'>
+                        <span className='flex items-start gap-2'>
+                            <span>
+                            Web analytics is available on the Publisher plan and above. <span className='text-green underline' onClick={() => updateRoute({route: '/pro', isExternal: true})}>Upgrade now &rarr;</span>
+                            </span>
+                        </span>
+                    </div>
+                ) : !isWebAnalyticsConfigured ? (
+                    <div className='mb-5 rounded-md border border-grey-200 bg-grey-50 px-4 py-2.5 text-sm dark:border-grey-900 dark:bg-grey-925'>
+                        <span className='flex items-start gap-2'>
+                            <span>
+                                Web analytics in Ghost is powered by <a className='text-green underline' href="https://tinybird.co" rel="noopener noreferrer" target='_blank'>Tinybird</a> and requires configuration to start collecting data. <a className='text-green underline' href="https://ghost.org/docs/" rel="noopener noreferrer" target='_blank'>Get started &rarr;</a>
+                            </span>
+                        </span>
+                    </div>
+                ) : (
+                    <Separator className="border-grey-200 dark:border-grey-900" />
+                )
             )}
             <Toggle
                 checked={trackEmailOpens}
diff --git a/apps/admin-x-settings/test/acceptance/membership/analytics.test.ts b/apps/admin-x-settings/test/acceptance/membership/analytics.test.ts
@@ -2,15 +2,11 @@ import {expect, test} from '@playwright/test';
 import {globalDataRequests, mockApi, responseFixtures, updatedSettingsResponse} from '@tryghost/admin-x-framework/test/acceptance';
 
 // Helper functions to reduce mockApi boilerplate
-const createConfigWithFeatureFlags = (trafficAnalytics: boolean, limits?: any) => ({
+const createConfigWithFeatureFlags = (limits?: any) => ({
     ...globalDataRequests.browseConfig,
     response: {
         config: {
             ...responseFixtures.config.config,
-            labs: {
-                ...responseFixtures.config.config.labs,
-                trafficAnalytics
-            },
             hostSettings: limits ? {
                 ...responseFixtures.config.config.hostSettings,
                 limits
@@ -31,14 +27,12 @@ const createSettingsWithAnalytics = (additionalSettings: Array<{key: string, val
 });
 
 const createMockApiConfig = (options: {
-    trafficAnalytics?: boolean;
     limits?: any;
     analyticsSettings?: Array<{key: string, value: any, is_read_only?: boolean}>;
     editSettingsResponse?: Array<{key: string, value: any}>;
     additionalRequests?: any;
 }) => {
     const {
-        trafficAnalytics = false,
         limits,
         analyticsSettings = [],
         editSettingsResponse,
@@ -47,7 +41,7 @@ const createMockApiConfig = (options: {
 
     const requests: any = {
         ...globalDataRequests,
-        browseConfig: createConfigWithFeatureFlags(trafficAnalytics, limits),
+        browseConfig: createConfigWithFeatureFlags(limits),
         ...additionalRequests
     };
 
@@ -69,7 +63,6 @@ const createMockApiConfig = (options: {
 test.describe('Analytics settings', async () => {
     test('Supports toggling analytics settings', async ({page}) => {
         const {lastApiRequests} = await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             analyticsSettings: [
                 {key: 'web_analytics', value: true},
                 {key: 'web_analytics_enabled', value: true},
@@ -163,59 +156,8 @@ test.describe('Analytics settings', async () => {
 
         await expect(newsletterClicksToggle).toBeDisabled();
     });
-
-    test('Shows web analytics toggle when feature flag is enabled', async ({page}) => {
-        await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
-            analyticsSettings: [
-                {key: 'web_analytics', value: true},
-                {key: 'web_analytics_enabled', value: true},
-                {key: 'web_analytics_configured', value: true}
-            ]
-        })});
-
-        await page.goto('/');
-
-        const section = page.getByTestId('analytics');
-
-        await expect(section).toBeVisible();
-
-        // Web analytics toggle should be visible when feature flag is enabled
-        await expect(section.getByLabel('Web analytics')).toBeVisible();
-        await expect(section.getByLabel('Web analytics')).toBeEnabled();
-        await expect(section.getByLabel('Web analytics')).toBeChecked();
-
-        // Other analytics toggles should still be visible
-        await expect(section.getByLabel('Newsletter opens')).toBeVisible();
-        await expect(section.getByLabel('Newsletter clicks')).toBeVisible();
-        await expect(section.getByLabel('Member sources')).toBeVisible();
-        await expect(section.getByLabel('Outbound link tagging')).toBeVisible();
-    });
-
-    test('Hides web analytics toggle when feature flag is disabled', async ({page}) => {
-        await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: false
-        })});
-
-        await page.goto('/');
-
-        const section = page.getByTestId('analytics');
-
-        await expect(section).toBeVisible();
-
-        // Web analytics toggle should not be visible when feature flag is disabled
-        await expect(section.getByLabel('Web analytics')).not.toBeVisible();
-
-        // Other analytics toggles should still be visible
-        await expect(section.getByLabel('Newsletter opens')).toBeVisible();
-        await expect(section.getByLabel('Newsletter clicks')).toBeVisible();
-        await expect(section.getByLabel('Member sources')).toBeVisible();
-        await expect(section.getByLabel('Outbound link tagging')).toBeVisible();
-    });
-
     test('Shows web analytics toggle as disabled when web_analytics_configured is false', async ({page}) => {
         await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             analyticsSettings: [
                 {key: 'web_analytics', value: true},
                 {key: 'web_analytics_enabled', value: false},
@@ -243,7 +185,6 @@ test.describe('Analytics settings', async () => {
 
     test('Shows web analytics toggle as enabled and respects user setting', async ({page}) => {
         const {lastApiRequests} = await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             analyticsSettings: [
                 {key: 'web_analytics', value: true},
                 {key: 'web_analytics_enabled', value: true},
@@ -279,7 +220,6 @@ test.describe('Analytics settings', async () => {
 
     test('Cannot toggle web analytics when disabled', async ({page}) => {
         await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             analyticsSettings: [
                 {key: 'web_analytics', value: false},
                 {key: 'web_analytics_enabled', value: false}
@@ -304,7 +244,6 @@ test.describe('Analytics settings', async () => {
 
     test('Can enable web analytics when it starts deselected', async ({page}) => {
         const {lastApiRequests} = await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             analyticsSettings: [
                 {key: 'web_analytics', value: false}, // Starts as false
                 {key: 'web_analytics_enabled', value: false}, // Feature is OFF but configurable
@@ -340,7 +279,6 @@ test.describe('Analytics settings', async () => {
 
     test('Shows upgrade CTA when analytics is limited (trial plan)', async ({page}) => {
         await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             limits: {
                 ...responseFixtures.config.config.hostSettings?.limits,
                 limitAnalytics: {
@@ -377,7 +315,6 @@ test.describe('Analytics settings', async () => {
 
     test('Shows configuration message when not limited but not configured', async ({page}) => {
         await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             limits: {}, // No limits
             analyticsSettings: [
                 {key: 'web_analytics', value: false},
@@ -402,7 +339,6 @@ test.describe('Analytics settings', async () => {
 
     test('Shows separator when configured and not limited', async ({page}) => {
         await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             limits: {}, // No limits
             analyticsSettings: [
                 {key: 'web_analytics', value: true},
@@ -427,7 +363,6 @@ test.describe('Analytics settings', async () => {
 
     test('Upgrade now button navigates to /pro', async ({page}) => {
         await mockApi({page, requests: createMockApiConfig({
-            trafficAnalytics: true,
             limits: {
                 ...responseFixtures.config.config.hostSettings?.limits,
                 limitAnalytics: {
diff --git a/apps/stats/README.md b/apps/stats/README.md
@@ -43,8 +43,6 @@ yarn
 yarn dev
 ```
 
-The Stats app is only displayed if the `trafficAnalytics` labs flag is enabled. With this enabled, the "Stats" tab should appear in your site's dashboard.
-
 ### Build
 
 ```bash
