PR for @eternal-echo: pwm: cv1800: Fix Output-Enable handling logic #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add devicetree binding for Sophgo CV1800B SoC reset controller. Signed-off-by: Jisheng Zhang <[email protected]> Signed-off-by: Ze Huang <[email protected]> Reviewed-by: Conor Dooley <[email protected]>
Add reset controller support for Sophgo CV1800B SoC reusing the reset-simple driver. Signed-off-by: Jisheng Zhang <[email protected]>
Add the reset device tree node and reset phandle to uart nodes. Although, the resets are deasserted by default. Add them for completeness. Signed-off-by: Jisheng Zhang <[email protected]>
Signed-off-by: AnnanLiu <[email protected]> Signed-off-by: Ze Huang <[email protected]>
…driver Commit 8ec99b0 ("irqchip/sifive-plic: Convert PLIC driver into aplatform driver")[1] broke timer initialization because the PLIC IRQdomain is no longer available in a TIMER_OF_DECLARE. The following error was observed: [ 0.024789] irq: no irq domain found for interrupt-controller@70000000 ! Following [2], fix this by moving the IRQ handling code to a platform driver. Tested by changing system clocksource. Link: https://lore.kernel.org/linux-arm-kernel/[email protected]/ [1] Link: https://lore.kernel.org/linux-riscv/[email protected]/ [2] Signed-off-by: Ze Huang <[email protected]>
Signed-off-by: Ze Huang <[email protected]>
dw_apb_timer_of cannot get clock resource without name "timer". Signed-off-by: Ze Huang <[email protected]>
The original code had a wrong logic for Output-Enable (OE) setting. It would only set OE if it was already set, which prevents PWM from working properly. Modified the code to: - Check and set OE only when not already set during enable - Clear OE when disabling PWM - Remove redundant OE state check This fixes the PWM output not working issue. Signed-off-by: eternal-echo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pwm: cv1800: fix Output-Enable (OE) logic to restore PWM output
Desciption: This PR is created on behalf of @eternal-echo. He has been working on bug fixing of Duo.
The original driver only set the OE bit when it was already set, which means
OE would never be enabled on first use. As a result, PWM output would not
appear even when period/duty_cycle and enable were correctly configured.
This patch fixes the OE control logic:
This resolves the issue of missing PWM signal on the output pin.
Tested on Sophgo CV1800 (Milkv Duo) board, using PWM1 (pin B11).
PWM signal verified via logic analyzer and sysfs interface.
To reproduce:
Pinmux was configured via:
Observed 1 kHz 80%/20% duty waveform on B11.
Signed-off-by: eternal-echo [email protected]