Skip to content

Commit 1d088a4

Browse files
committed
feat(oxlint-config): review fixes
1 parent d25374a commit 1d088a4

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

packages/oxlint-config/src/plugin/import-order.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,15 +350,18 @@ export default {
350350
return
351351
}
352352

353+
const hasSkippedImports = hasSkippedImportsBetween(imports, items)
353354
const unorderedPair = getFirstUnorderedPair(items)
354-
const invalidNewlinePair = getInvalidNewlinePair(sourceCode, items, options)
355+
const invalidNewlinePair = hasSkippedImports
356+
? null
357+
: getInvalidNewlinePair(sourceCode, items, options)
355358

356359
if (!unorderedPair && !invalidNewlinePair) {
357360
return
358361
}
359362

360363
const fix = canFix(sourceCode, items)
361-
&& !hasSkippedImportsBetween(imports, items)
364+
&& !hasSkippedImports
362365
? fixer => fixer.replaceTextRange(
363366
getImportBlockRange(items),
364367
getFixedImportText(sourceCode, items, options)

packages/oxlint-config/src/test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export default {
1212
vitest: true
1313
},
1414
plugins: ['typescript'],
15+
jsPlugins: ['@trigen/oxlint-config/plugin'],
1516
rules: {
1617
'eslint/max-classes-per-file': 'off',
1718
'eslint/no-magic-numbers': 'off',

0 commit comments

Comments
 (0)