refactor: 수익 계산 로직을 FuturesPostion 엔티티로 옮겨서 응집력 향상

Author: sgh002400

Tradin-Core/src/main/java/com/tradin/core/futuresPosition/domain/FuturesPosition.java

@@ -118,15 +118,14 @@ public boolean isPositionShort() {
         return this.tradingType.isShort();
     }
 
-    public Amount calculateProfitAmount(Price currentPrice) {
-        BigDecimal entryPriceValue = this.entryPrice.getValue();
-        BigDecimal currentPriceValue = currentPrice.getValue();
-        BigDecimal amountValue = this.amount.getValue();
+    public Amount calculateProfitAmount(Price price) {
+        BigDecimal currentPrice = price.getValue();
+        BigDecimal entryPrice = this.entryPrice.getValue();
 
-        if (this.tradingType.isLong()) {
-            return Amount.of(currentPriceValue.subtract(entryPriceValue).multiply(amountValue).divide(entryPriceValue, 2, RoundingMode.DOWN));
-        }
+        BigDecimal profit = this.tradingType.isLong()
+            ? currentPrice.subtract(entryPrice).multiply(amount.getValue()).divide(entryPrice, 2, RoundingMode.DOWN)
+            : entryPrice.subtract(currentPrice).multiply(amount.getValue()).divide(entryPrice, 2, RoundingMode.DOWN);
 
-        return Amount.of(entryPriceValue.subtract(currentPriceValue).multiply(amountValue).divide(entryPriceValue, 2, RoundingMode.DOWN));
+        return Amount.of(profit);
     }
 }

Tradin-Core/src/main/java/com/tradin/core/futuresPosition/service/FuturesPositionService.java

@@ -38,19 +38,7 @@ public Optional<FuturesPosition> findOpenFuturesPositionByAccountAndCoinType(Lon
     }
 
     public Amount calculateProfitAmount(FuturesPosition futuresPosition) {
-        BigDecimal currentPrice = priceCache.getPrice(futuresPosition.getCoinType()).getValue();
-        BigDecimal entryPrice = futuresPosition.getEntryPrice().getValue();
-
-        if (futuresPosition.isPositionLong()) {
-            return Amount.of(
-                currentPrice.subtract(entryPrice)
-                    .multiply(futuresPosition.getAmount().getValue())
-                    .divide(futuresPosition.getEntryPrice().getValue(),2, RoundingMode.DOWN));
-        }
-
-        return Amount.of(
-            entryPrice.subtract(currentPrice)
-                .multiply(futuresPosition.getAmount().getValue())
-                .divide(futuresPosition.getEntryPrice().getValue(), 2, RoundingMode.DOWN));
+        Price currentPrice = priceCache.getPrice(futuresPosition.getCoinType());
+        return futuresPosition.calculateProfitAmount(currentPrice);
     }
 }