Skip to content

Commit 8cbe19e

Browse files
TomerNewmank8s-ci-robot
authored andcommitted
Revert rbac addition for BuildRun resource
Because we will not use Shipwright, We should revert kmm to not have RBAC for Shipwrights resources like BuildRun. This commit reverts to the old RBAC configuration.
1 parent d641bbe commit 8cbe19e

File tree

4 files changed

+0
-23
lines changed

4 files changed

+0
-23
lines changed

config/rbac-hub/role.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -86,16 +86,6 @@ rules:
8686
- list
8787
- patch
8888
- watch
89-
- apiGroups:
90-
- shipwright.io
91-
resources:
92-
- buildruns
93-
verbs:
94-
- create
95-
- delete
96-
- list
97-
- patch
98-
- watch
9989
- apiGroups:
10090
- work.open-cluster-management.io
10191
resources:

config/rbac/role.yaml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -127,14 +127,3 @@ rules:
127127
- patch
128128
- update
129129
- watch
130-
- apiGroups:
131-
- shipwright.io
132-
resources:
133-
- buildruns
134-
verbs:
135-
- create
136-
- delete
137-
- get
138-
- list
139-
- patch
140-
- watch

internal/controllers/hub/managedclustermodule_reconciler.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ type ManagedClusterModuleReconciler struct {
6767
//+kubebuilder:rbac:groups=kmm.sigs.x-k8s.io,resources=modulebuildsignconfigs/status,verbs=get;update;patch
6868
//+kubebuilder:rbac:groups=work.open-cluster-management.io,resources=manifestworks,verbs=get;list;watch;create;update;patch;delete
6969
//+kubebuilder:rbac:groups=cluster.open-cluster-management.io,resources=managedclusters,verbs=get;list;watch
70-
//+kubebuilder:rbac:groups=shipwright.io,resources=buildruns,verbs=list;watch;create;patch;delete
7170
//+kubebuilder:rbac:groups=core,resources=pods,verbs=create;delete;list;patch;watch
7271
//+kubebuilder:rbac:groups="core",resources=secrets,verbs=get;list;watch
7372
//+kubebuilder:rbac:groups="core",resources=configmaps,verbs=get;list;watch

internal/controllers/module_reconciler.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import (
3434
//+kubebuilder:rbac:groups=apps,resources=daemonsets,verbs=create;delete;get;list;patch;watch
3535
//+kubebuilder:rbac:groups=cluster.open-cluster-management.io,resources=clusterclaims,resourceNames=kernel-versions.kmm.node.kubernetes.io,verbs=delete;patch;update
3636
//+kubebuilder:rbac:groups=cluster.open-cluster-management.io,resources=clusterclaims,verbs=create;get;list;watch
37-
//+kubebuilder:rbac:groups=shipwright.io,resources=buildruns,verbs=get;list;watch;create;patch;delete
3837
//+kubebuilder:rbac:groups=core,resources=configmaps,verbs=get;list;watch
3938
//+kubebuilder:rbac:groups=core,resources=namespaces,verbs=get;list;patch;watch
4039
//+kubebuilder:rbac:groups=core,resources=nodes,verbs=get;list;watch;patch

0 commit comments

Comments
 (0)