Skip to content

Commit d414599

Browse files
change basic logic for independent test
1 parent 78e8ea0 commit d414599

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

src/main/kotlin/binaryTree/PreorderTraverse.kt

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,18 @@ package binaryTree
77
*/
88

99

10-
fun preorderTraverse(root: TreeNode?, traverse: MutableList<Int>) {
11-
root ?: return
10+
fun preorderTraverse(root: TreeNode?): List<Int> {
11+
root ?: return listOf()
12+
val nodes = mutableListOf<Int>()
1213

13-
traverse.add(root.value)
14-
preorderTraverse(root.left, traverse)
15-
preorderTraverse(root.right, traverse)
14+
fun dfs(root: TreeNode?) {
15+
root ?: return
16+
17+
nodes.add(root.value)
18+
dfs(root.left)
19+
dfs(root.right)
20+
}
21+
dfs(root)
22+
23+
return nodes
1624
}

src/test/kotlin/binaryTree/PreorderTraverseTest.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ class PreorderTraverseTest {
1212
root.right = TreeNode(3)
1313

1414
val expected = listOf(1, 2, 3)
15-
val res = mutableListOf<Int>()
16-
preorderTraverse(root, res)
15+
val res = preorderTraverse(root)
1716

1817
assertArrayEquals(expected.toIntArray(), res.toIntArray())
1918
}
@@ -24,8 +23,7 @@ class PreorderTraverseTest {
2423
val root: TreeNode? = null
2524

2625
val expected = emptyList<Int>()
27-
val res = mutableListOf<Int>()
28-
preorderTraverse(root, res)
26+
val res = preorderTraverse(root)
2927

3028
assertArrayEquals(expected.toIntArray(), res.toIntArray())
3129
}

0 commit comments

Comments
 (0)