drt: incremental PA trial #8918
Open
+1,692
−1,526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: osamahammad21 <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
Signed-off-by: Osama <[email protected]>
…ROAD into drt-incremental-pa Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
This reverts commit d6083e8. Signed-off-by: Eder Monteiro <[email protected]>
This reverts commit 9279035. Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
…ate/OpenROAD into drt-incremental-pa
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: osamahammad21 <[email protected]>
Signed-off-by: Osama <[email protected]>
…ROAD into drt-incremental-pa
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Contributor
|
Updates on design metrics here: The-OpenROAD-Project/OpenROAD-flow-scripts#3681 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| const frCoord base_idxX = coord_x / (frCoord) xgp.getSpacing(); | ||
| const frCoord base_idxY = coord_y / (frCoord) ygp.getSpacing(); | ||
| std::set<frCoord> x_indices{base_idxX}; |
Contributor
There was a problem hiding this comment.
warning: no header providing "std::set" is directly included [misc-include-cleaner]
src/drt/src/db/obj/frBlock.h:8:
- #include <string>
+ #include <set>
+ #include <string>
src/drt/src/db/obj/frBlock.h
Outdated
| std::vector<odb::Point> sol; | ||
| for (auto& x : x_indices) { | ||
| for (auto& y : y_indices) { | ||
| sol.push_back(odb::Point(x, y)); |
Contributor
There was a problem hiding this comment.
warning: use emplace_back instead of push_back [modernize-use-emplace]
Suggested change
| sol.push_back(odb::Point(x, y)); | |
| sol.emplace_back(x, y); |
| }), | ||
| insts_.end()); | ||
| nets_.erase(std::remove_if(nets_.begin(), | ||
| nets_.end(), |
Contributor
There was a problem hiding this comment.
warning: use a ranges version of this algorithm [modernize-use-ranges]
Suggested change
| nets_.end(), | |
| nets_.erase(std::ranges::remove_if(nets_, | |
| , |
| } | ||
| odb::dbMasterType getMasterType() { return masterType_; } | ||
| bool hasPinAccessUpdate() const { return !updated_pa_indices_.empty(); } | ||
| const std::set<int>& getUpdatedPAIndices() const |
Contributor
There was a problem hiding this comment.
warning: no header providing "std::set" is directly included [misc-include-cleaner]
src/drt/src/db/obj/frMaster.h:7:
- #include <string>
+ #include <set>
+ #include <string>| const auto inst_it = insts_set_.find(inst); | ||
| if (inst_it == insts_set_.end()) { | ||
| logger_->error( | ||
| DRT, 9419, "Inst {} not found in insts_set_", inst->getName()); |
Contributor
There was a problem hiding this comment.
warning: no header providing "drt::DRT" is directly included [misc-include-cleaner]
src/drt/src/pa/FlexPA_row_pattern.cpp:21:
- #include "frProfileTask.h"
+ #include "frBaseTypes.h"
+ #include "frProfileTask.h"Signed-off-by: Eder Monteiro <[email protected]>
maliberty
requested review from
osamahammad21
and removed request for
maliberty
Signed-off-by: osamahammad21 <[email protected]>
osamahammad21
previously approved these changes
Dec 1, 2025
Signed-off-by: osamahammad21 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.