[Autotuner] Refactor set_seed #3172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luarss
commented
May 17, 2025
luarss
commented
- Achieves separation of concerns: set_seed in another function
- cleanup unused imports
- reorganise utils.py with clearer comments
vvbandeira
requested changes
Jul 3, 2025
Comment on lines
101
to
102
| import torch | ||
| import random |
Member
There was a problem hiding this comment.
Adding the import inside a def leads to late dependency resolution. I would prefer to fail fast in this case.
luarss
force-pushed
the
topic/refactor-seed
branch
from
5752802 to
a93630e
Compare
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
luarss
force-pushed
the
topic/refactor-seed
branch
from
a93630e to
f4e9d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.