Merge pull request #91 from Tencent/fix/popup

LeeJim · web-flow · commit 194dedd67f3e · 2022-01-08T23:36:17.000+08:00
fix(popup): correct event param
diff --git a/src/popup/popup.ts b/src/popup/popup.ts
@@ -66,12 +66,12 @@ export default class Popup extends SuperComponent {
   onOverlayClick() {
     const { closeOnOverlayClick } = this.properties;
     if (closeOnOverlayClick) {
-      this.triggerEvent('visible-change', { visiable: false });
+      this.triggerEvent('visible-change', { visible: false });
     }
   }
 
   onCloseClick() {
-    this.triggerEvent('visible-change', { visiable: false });
+    this.triggerEvent('visible-change', { visible: false });
   }
 
   preventEvent() {}

Original file line number	Diff line number	Diff line change
`@@ -66,12 +66,12 @@ export default class Popup extends SuperComponent {`
`66`	`66`	`onOverlayClick() {`
`67`	`67`	`const { closeOnOverlayClick } = this.properties;`
`68`	`68`	`if (closeOnOverlayClick) {`
`69`		`- this.triggerEvent('visible-change', { visiable: false });`
	`69`	`+ this.triggerEvent('visible-change', { visible: false });`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`onCloseClick() {`
`74`		`- this.triggerEvent('visible-change', { visiable: false });`
	`74`	`+ this.triggerEvent('visible-change', { visible: false });`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`preventEvent() {}`