Skip to content

Commit ef38c8d

Browse files
KIRA-Zeemikasa987654SkyeBeFreeman
authored
fix:Replace with String inside @ConditionalOnClass to fix #1749. (#1755)
Co-authored-by: KIRA_Z <[email protected]> Co-authored-by: Haotian Zhang <[email protected]>
1 parent 625e0e3 commit ef38c8d

File tree

10 files changed

+10
-19
lines changed

10 files changed

+10
-19
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66
- [refactor:optimize config locate.](https://github.com/Tencent/spring-cloud-tencent/pull/1742)
77
- [feat:support async metadata transfer.](https://github.com/Tencent/spring-cloud-tencent/pull/1744)
88
- [feat: support TagUtils, ContextToHeaderInterceptor in TSF.](https://github.com/Tencent/spring-cloud-tencent/pull/1753)
9+
- [fix:replace with string inside @ConditionalOnClass.](https://github.com/Tencent/spring-cloud-tencent/pull/1755)
910
- [deps:upgrade GitHub Actions to v5.](https://github.com/Tencent/spring-cloud-tencent/pull/1757)

spring-cloud-starter-tencent-polaris-circuitbreaker/src/main/java/com/tencent/cloud/polaris/circuitbreaker/config/GatewayPolarisCircuitBreakerAutoConfiguration.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,10 @@
2020
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2121
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2222
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
23-
import org.springframework.cloud.gateway.config.GatewayAutoConfiguration;
2423
import org.springframework.cloud.gateway.config.conditional.ConditionalOnEnabledFilter;
2524
import org.springframework.cloud.gateway.filter.factory.FallbackHeadersGatewayFilterFactory;
2625
import org.springframework.context.annotation.Bean;
2726
import org.springframework.context.annotation.Configuration;
28-
import org.springframework.web.reactive.DispatcherHandler;
2927

3028
/**
3129
* GatewayPolarisCircuitBreakerAutoConfiguration.
@@ -34,7 +32,7 @@
3432
*/
3533
@Configuration(proxyBeanMethods = false)
3634
@ConditionalOnProperty(name = "spring.cloud.gateway.enabled", matchIfMissing = true)
37-
@ConditionalOnClass({ DispatcherHandler.class, GatewayAutoConfiguration.class})
35+
@ConditionalOnClass(name = {"org.springframework.web.reactive.DispatcherHandler", "org.springframework.cloud.gateway.config.GatewayAutoConfiguration"})
3836
public class GatewayPolarisCircuitBreakerAutoConfiguration {
3937

4038
@Bean

spring-cloud-starter-tencent-polaris-circuitbreaker/src/main/java/com/tencent/cloud/polaris/circuitbreaker/config/PolarisCircuitBreakerFeignClientAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2828
import org.springframework.cloud.client.circuitbreaker.CircuitBreakerFactory;
2929
import org.springframework.cloud.openfeign.CircuitBreakerNameResolver;
30-
import org.springframework.cloud.openfeign.FeignClientFactoryBean;
3130
import org.springframework.cloud.openfeign.Targeter;
3231
import org.springframework.context.annotation.Bean;
3332
import org.springframework.context.annotation.Configuration;
@@ -39,7 +38,7 @@
3938
* @author seansyyu 2023-02-28
4039
*/
4140
@Configuration(proxyBeanMethods = false)
42-
@ConditionalOnClass({Feign.class, FeignClientFactoryBean.class})
41+
@ConditionalOnClass(name = {"feign.Feign", "org.springframework.cloud.openfeign.FeignClientFactoryBean"})
4342
@ConditionalOnPolarisCircuitBreakerEnabled
4443
public class PolarisCircuitBreakerFeignClientAutoConfiguration {
4544

spring-cloud-starter-tencent-polaris-circuitbreaker/src/main/java/com/tencent/cloud/polaris/circuitbreaker/endpoint/PolarisCircuitBreakerEndpointAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import com.tencent.cloud.polaris.context.ServiceRuleManager;
2222

2323
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint;
24-
import org.springframework.boot.actuate.endpoint.annotation.Endpoint;
2524
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
2625
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2726
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
@@ -34,7 +33,7 @@
3433
* @author wenxuan70
3534
*/
3635
@Configuration(proxyBeanMethods = false)
37-
@ConditionalOnClass(Endpoint.class)
36+
@ConditionalOnClass(name = "org.springframework.boot.actuate.endpoint.annotation.Endpoint")
3837
@ConditionalOnPolarisCircuitBreakerEnabled
3938
public class PolarisCircuitBreakerEndpointAutoConfiguration {
4039

spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/endpoint/PolarisConfigEndpointAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import com.tencent.cloud.polaris.config.config.PolarisConfigProperties;
2222

2323
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint;
24-
import org.springframework.boot.actuate.endpoint.annotation.Endpoint;
2524
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2625
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2726
import org.springframework.context.annotation.Bean;
@@ -33,7 +32,7 @@
3332
* @author shuiqingliu
3433
**/
3534
@Configuration(proxyBeanMethods = false)
36-
@ConditionalOnClass(Endpoint.class)
35+
@ConditionalOnClass(name = "org.springframework.boot.actuate.endpoint.annotation.Endpoint")
3736
@ConditionalOnPolarisConfigEnabled
3837
public class PolarisConfigEndpointAutoConfiguration {
3938

spring-cloud-starter-tencent-polaris-discovery/src/main/java/com/tencent/cloud/polaris/endpoint/PolarisDiscoveryEndpointAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import com.tencent.cloud.polaris.discovery.PolarisDiscoveryHandler;
2323

2424
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint;
25-
import org.springframework.boot.actuate.endpoint.annotation.Endpoint;
2625
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2726
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2827
import org.springframework.cloud.client.discovery.DiscoveryClient;
@@ -35,7 +34,7 @@
3534
* @author shuiqingliu
3635
**/
3736
@Configuration(proxyBeanMethods = false)
38-
@ConditionalOnClass(Endpoint.class)
37+
@ConditionalOnClass(name = "org.springframework.boot.actuate.endpoint.annotation.Endpoint")
3938
@ConditionalOnPolarisDiscoveryEnabled
4039
public class PolarisDiscoveryEndpointAutoConfiguration {
4140

spring-cloud-starter-tencent-polaris-ratelimit/src/main/java/com/tencent/cloud/polaris/ratelimit/endpoint/PolarisRateLimitRuleEndpointAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import com.tencent.cloud.polaris.ratelimit.config.PolarisRateLimitProperties;
2323

2424
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint;
25-
import org.springframework.boot.actuate.endpoint.annotation.Endpoint;
2625
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2726
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2827
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
@@ -35,7 +34,7 @@
3534
* @author shuiqingliu
3635
**/
3736
@Configuration(proxyBeanMethods = false)
38-
@ConditionalOnClass(Endpoint.class)
37+
@ConditionalOnClass(name = "org.springframework.boot.actuate.endpoint.annotation.Endpoint")
3938
@ConditionalOnPolarisEnabled
4039
@ConditionalOnProperty(name = "spring.cloud.polaris.ratelimit.enabled", matchIfMissing = true)
4140
public class PolarisRateLimitRuleEndpointAutoConfiguration {

spring-cloud-starter-tencent-polaris-router/src/main/java/com/tencent/cloud/polaris/router/endpoint/PolarisRouterEndpointAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import com.tencent.cloud.polaris.context.ServiceRuleManager;
2222

2323
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint;
24-
import org.springframework.boot.actuate.endpoint.annotation.Endpoint;
2524
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2625
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2726
import org.springframework.context.annotation.Bean;
@@ -33,7 +32,7 @@
3332
* @author lepdou 2022-07-25
3433
**/
3534
@Configuration(proxyBeanMethods = false)
36-
@ConditionalOnClass(Endpoint.class)
35+
@ConditionalOnClass(name = "org.springframework.boot.actuate.endpoint.annotation.Endpoint")
3736
@ConditionalOnPolarisEnabled
3837
public class PolarisRouterEndpointAutoConfiguration {
3938

spring-cloud-tencent-commons/src/main/java/com/tencent/cloud/common/metadata/endpoint/PolarisMetadataEndpointAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import com.tencent.cloud.common.metadata.StaticMetadataManager;
2121

2222
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnAvailableEndpoint;
23-
import org.springframework.boot.actuate.endpoint.annotation.Endpoint;
2423
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
2524
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
2625
import org.springframework.context.annotation.Bean;
@@ -32,7 +31,7 @@
3231
* @author shuiqingliu
3332
**/
3433
@Configuration(proxyBeanMethods = false)
35-
@ConditionalOnClass(Endpoint.class)
34+
@ConditionalOnClass(name = "org.springframework.boot.actuate.endpoint.annotation.Endpoint")
3635
public class PolarisMetadataEndpointAutoConfiguration {
3736

3837
@Bean

spring-cloud-tencent-plugin-starters/spring-cloud-starter-tencent-gateway-plugin/src/main/java/com/tencent/cloud/plugin/gateway/GatewayPluginAutoConfiguration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
4444
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
4545
import org.springframework.cloud.gateway.config.GatewayAutoConfiguration;
46-
import org.springframework.cloud.gateway.filter.GlobalFilter;
4746
import org.springframework.cloud.loadbalancer.support.LoadBalancerClientFactory;
4847
import org.springframework.context.ApplicationContext;
4948
import org.springframework.context.ApplicationEventPublisher;
@@ -70,7 +69,7 @@ public class GatewayPluginAutoConfiguration {
7069
@ConditionalOnProperty(value = "spring.cloud.tencent.plugin.scg.context.enabled", matchIfMissing = true)
7170
@ConditionalOnPolarisConfigEnabled
7271
@AutoConfigureBefore(GatewayAutoConfiguration.class)
73-
@ConditionalOnClass(GlobalFilter.class)
72+
@ConditionalOnClass(name = "org.springframework.cloud.gateway.filter.GlobalFilter")
7473
@Import(ContextGatewayProperties.class)
7574
public static class ContextPluginConfiguration {
7675

0 commit comments

Comments
 (0)