Merge pull request #348 from SourceFellows/master

Added the ability to debug the plugin through the Terraform Plugin SDK.

Author: ggongaware

README.md

@@ -27,6 +27,18 @@ This section is here to both serve as a reminder to contributers of areas for im
 
 When contributing, please also add documentation to help other users.
 
+### Debugging the provider
+
+Debugging is available for this provider through the Terraform Plugin SDK versions 2.0.0. Therefore the plugin can be 
+started with the debugging flag `--debug`.
+
+For example (using [delve](https://github.com/go-delve/delve) as Debugger):
+```bash
+dlv exec --headless ./terraform-provider-my-provider -- --debug
+```
+
+For more information about debugging a provider please see: [Debugger-Based Debugging](https://www.terraform.io/docs/extend/debugging.html#debugger-based-debugging)
+
 ## Useful links
 
 * [Proxmox](https://www.proxmox.com/en/)

main.go

@@ -1,15 +1,34 @@
 package main
 
 import (
+	"context"
+	"flag"
 	"github.com/Telmate/terraform-provider-proxmox/proxmox"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/plugin"
+	"log"
 )
 
 func main() {
-	plugin.Serve(&plugin.ServeOpts{
+
+	var debugMode bool
+
+	flag.BoolVar(&debugMode, "debug", false, "set to true to run the provider with support for debuggers like delve")
+	flag.Parse()
+
+	opts := &plugin.ServeOpts{
 		ProviderFunc: func() *schema.Provider {
 			return proxmox.Provider()
 		},
-	})
+	}
+
+	if debugMode {
+		err := plugin.Debug(context.Background(), "registry.terraform.io/telmate/proxmox", opts)
+		if err != nil {
+			log.Fatal(err.Error())
+		}
+		return
+	}
+
+	plugin.Serve(opts)
 }

proxmox/provider.go

@@ -6,8 +6,8 @@ import (
 	"os"
 	"regexp"
 	"strconv"
-	"sync"
 	"strings"
+	"sync"
 
 	pxapi "github.com/Telmate/proxmox-api-go/proxmox"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -213,7 +213,7 @@ func getClient(pm_api_url string, pm_user string, pm_password string, pm_api_tok
 	// API authentication
 	if pm_api_token_id != "" && pm_api_token_secret != "" {
 		// Unsure how to get an err for this
-		client.SetAPIToken( pm_api_token_id, pm_api_token_secret)
+		client.SetAPIToken(pm_api_token_id, pm_api_token_secret)
 	}
 
 	if err != nil {

proxmox/resource_vm_qemu.go

@@ -211,10 +211,10 @@ func resourceVmQemu() *schema.Resource {
 				Type:     schema.TypeString,
 				Optional: true,
 			},
-                        "args": {
-                                Type:     schema.TypeString,
-                                Optional: true,
-                        },
+			"args": {
+				Type:     schema.TypeString,
+				Optional: true,
+			},
 			"memory": {
 				Type:     schema.TypeInt,
 				Optional: true,