🏗️ Consolidate skills into ai-coding-config plugin

[TechNickAI]

Summary

• Merge standalone skills plugin into core ai-coding-config plugin
• Move skills from plugins/skills/skills/ to plugins/core/skills/
• Bump marketplace and core plugin version to 5.0.0
• Update all documentation and symlinks

Why

Following the same pattern as PR #14 (agents consolidation), this removes the awkward skills:brainstorming naming pattern in favor of ai-coding-config:brainstorming.

This completes the consolidation work started in PR #14, creating one unified ai-coding-config plugin containing:

• Commands
• Agents
• Skills
• Context

Following the pattern used by superpowers and other Claude Code marketplaces.

Breaking Changes

Users who installed the skills plugin separately need to reinstall from ai-coding-config:

/plugin install ai-coding-config

Test plan

• Verify skills are accessible via @ai-coding-config:brainstorming pattern
• Confirm symlinks work correctly: .claude/skills → plugins/core/skills
• Test /ai-coding-config command handles new structure
• Verify all 5 skills load properly

🤖 Generated with Claude Code

[claude]

Code Review - PR #15: Consolidate skills into ai-coding-config plugin

Summary

This PR successfully consolidates the standalone skills plugin into the core ai-coding-config plugin, completing the architecture unification started in PR #14. The changes are well-executed with comprehensive documentation updates.

✅ Strengths

1. Architectural Consistency

• Follows the established pattern from PR 🏗️ Consolidate agents into core ai-coding-config plugin #14 (agents consolidation)
• Creates a unified plugin structure: commands, agents, skills, and context all in one place
• Eliminates the awkward skills:brainstorming naming in favor of cleaner ai-coding-config:brainstorming
• Aligns with the plugin-first architecture principle documented in CLAUDE.md

2. Complete Documentation Updates
All references to the old path have been properly updated:

• .claude-plugin/marketplace.json - Removed separate skills plugin entry
• CLAUDE.md - Updated project structure section (line 24)
• AGENTS.md - Updated project structure (line 24) and important notes (line 84)
• README.md - Updated skills path reference (line 91)
• plugins/core/commands/ai-coding-config.md - Updated installation mapping (lines 160, 428)

3. Clean File Migration

• All 5 skills moved successfully: brainstorming, research, skill-creator, systematic-debugging, youtube-transcript-analyzer
• Symlink properly updated: .claude/skills → plugins/core/skills
• Old plugins/skills/ directory completely removed
• No leftover references to old paths (verified with grep)

4. Version Management

• Appropriate major version bump to 5.0.0 (breaking change)
• Clear communication about breaking changes in PR description
• Plugin metadata properly updated in both marketplace.json and plugin.json

5. Skills Content Quality
Spot-checked skills show high quality:

• Proper YAML frontmatter with descriptions under 75 chars (per CLAUDE.md guidelines)
• Well-structured content with clear XML sections
• Good documentation of when to use each skill
• Follows project conventions

🔍 Minor Observations

1. Test Plan Checklist
The PR description includes a test plan checklist that hasn't been checked off yet. Before merging, ensure:

• Skills accessible via @ai-coding-config:brainstorming pattern
• Symlinks working correctly
• /ai-coding-config command handles new structure
• All 5 skills load properly

2. Migration Path for Users
The breaking changes section clearly states users need to reinstall, which is good. Consider adding to the PR description or a migration guide:

• Users should run /plugin uninstall skills first (if they had it)
• Then /plugin install ai-coding-config or /plugin update ai-coding-config

🎯 Recommendations

Before Merging:

1. Complete the test plan checklist items in the PR description
2. Verify skills load in a clean environment
3. Test the /ai-coding-config command recognizes the new structure

Post-Merge:

1. Update any external documentation or blog posts that reference the old skills plugin
2. Consider adding a note in the marketplace about the deprecation of the standalone skills plugin

📊 Impact Assessment

Risk Level: Low

• Well-contained change following proven pattern
• Comprehensive documentation updates
• Clear migration path for users

Breaking Changes: Yes

• Users with standalone skills plugin must reinstall
• Properly documented with clear upgrade path

Performance: Neutral

• No performance impact expected

Security: No concerns identified

• File moves only, no code logic changes

✅ Verdict

LGTM with minor verification needed

This is a solid PR that completes the plugin consolidation work. The implementation is clean, documentation is comprehensive, and it follows established patterns. Just verify the test plan items before merging.

The consolidation makes the plugin ecosystem cleaner and more maintainable. Users get a single unified plugin instead of having to install multiple related plugins.

Great work following through on the architecture vision! 🎉

[claude]

Code Review

Summary

This PR consolidates the standalone skills plugin into the core plugin, completing the consolidation work started in PR #14. The changes are well-structured and follow a clear architectural pattern.

Positive Aspects

Architecture & Design

• Excellent consolidation strategy that mirrors PR 🏗️ Consolidate agents into core ai-coding-config plugin #14's agent consolidation
• Clean removal of the awkward skills:brainstorming pattern in favor of ai-coding-config:brainstorming
• Proper semantic versioning (major bump to 5.0.0 for breaking changes)
• Consistent with superpowers and other Claude Code marketplace patterns

Code Quality

• All file moves are clean (no modifications, just relocations)
• Symlink updates are correct: .claude/skills → ../plugins/core/skills
• Complete removal of the old plugins/skills/ plugin infrastructure
• Documentation updates are comprehensive (marketplace.json, AGENTS.md, README.md, ai-coding-config.md)

Migration Path

• Clear breaking change documentation
• Simple migration path for users (/plugin install ai-coding-config)
• Command file updated with correct paths for symlink compatibility checks

Areas for Improvement

Test Plan Completion
The PR description includes unchecked test items:

• Verify skills are accessible via @ai-coding-config:brainstorming pattern
• Confirm symlinks work correctly
• Test /ai-coding-config command handles new structure
• Verify all 5 skills load properly

Recommendation: Before merging, verify these test items and update the PR description. Even if CI is pending, manual verification would strengthen confidence.

Documentation Consistency
The command file (ai-coding-config.md) updates paths in three locations but could benefit from a note about the version change:

• Line 299: Updated example paths
• Line 428: Updated symlink compatibility check

Suggestion: Consider adding a migration note in the command file's version history or changelog section (if one exists) to help users understand why paths changed.

CI Status
Current checks show:

• claude - skipping
• Cursor Bugbot - pending
• claude-review - pending

Recommendation: Ensure all CI checks pass before merging, especially the claude-review check which may catch plugin-specific issues.

Potential Issues

None Identified

• No security concerns
• No performance regressions expected (file structure change only)
• No code logic changes (pure file relocation)
• Symlinks are correctly updated
• All references to old paths appear to be updated

Files Verified

• ✅ .claude-plugin/marketplace.json - version bumped, skills plugin removed
• ✅ .claude/skills symlink - correctly points to new location
• ✅ AGENTS.md - documentation updated
• ✅ README.md - path reference updated
• ✅ plugins/core/.claude-plugin/plugin.json - version and description updated
• ✅ plugins/core/commands/ai-coding-config.md - symlink paths updated
• ✅ All skill files - moved without modification
• ✅ plugins/skills/.claude-plugin/plugin.json - properly deleted

Recommendation

Approve with minor suggestions:

This is a clean consolidation PR that improves the plugin architecture. The breaking changes are well-documented and the migration path is clear.

Before merging:

1. Complete the test plan checklist in the PR description
2. Ensure CI checks pass (especially claude-review)
3. Consider adding a CHANGELOG entry or migration note for the 4.0.0 → 5.0.0 upgrade

After merging:

1. Consider announcing the breaking change to users who may have installed the skills plugin separately
2. Update any external documentation that references the old skills: naming pattern

Great work maintaining consistency across the plugin ecosystem! This follows the same solid pattern as PR #14.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[claude]

Code Review: Skills Consolidation

This PR successfully consolidates the standalone skills plugin into the ai-coding-config core plugin, following the same pattern established in PR #14 for agents. Overall, this is a clean architectural improvement that simplifies the plugin structure.

Positive Observations

Architecture & Consistency:

• Follows the established pattern from PR 🏗️ Consolidate agents into core ai-coding-config plugin #14 (agents consolidation)
• Maintains the plugin-first architecture correctly
• All symlinks updated properly (.claude/skills → plugins/core/skills)
• Deprecated plugin directory fully removed
• Version bumps are appropriate (marketplace and core plugin both → 5.0.0)

Documentation Updates:

• AGENTS.md correctly updated to reflect new structure
• Plugin metadata properly reflects the consolidated content
• Migration path clearly documented in PR description

Code Quality:

• Clean file moves with no code changes (reducing risk)
• Proper cleanup of old plugin.json
• Symlink compatibility checks added to /ai-coding-config command

Issues Found

1. README.md Directory Tree Outdated (Line 197-198)

The directory tree in README.md still shows the old structure:

│   ├── agents/agents/                # All specialized agents
│   ├── skills/skills/                # Autonomous capabilities

Should be updated to:

│   ├── core/
│   │   ├── agents/                   # All specialized agents
│   │   ├── commands/                 # All workflow commands
│   │   ├── skills/                   # Autonomous capabilities
│   │   └── context.md                # Identity and philosophy
│   └── personalities/                # Personality plugins

The current tree doesn't accurately represent the actual structure where agents and skills both live under plugins/core/.

Recommendations

Before Merge:

• Fix the README.md directory tree to accurately reflect the consolidated structure

Testing Suggestions:
Consider verifying these items from the test plan:

• Skills accessible via @ai-coding-config:brainstorming pattern (not @skills:brainstorming)
• Symlinks resolve correctly in fresh clone
• /ai-coding-config command properly detects and migrates old symlinks
• All 5 skills (brainstorming, research, skill-creator, systematic-debugging, youtube-transcript-analyzer) load properly

Security & Performance

No security concerns identified. This is purely a structural refactoring with no logic changes.

Breaking Changes

The breaking change is properly documented. Users with the separate skills plugin will need to reinstall from ai-coding-config, which is reasonable for a major version bump (4.0.0 → 5.0.0).

Overall Assessment

This is a well-executed consolidation that improves the plugin architecture. With the README.md fix, this will be ready to merge. The change aligns well with the project's plugin-first philosophy and simplifies the user experience by reducing the number of separate plugins to manage.

Status: Approve with minor documentation fix required

[cursor]

Bug: Install command references removed skills plugin

The install commands /plugin install ai-coding-config skills in README.md and /plugin install ai-coding-config agents skills in the command file reference a skills plugin that no longer exists after this PR removed it from marketplace.json. Since skills are now consolidated into the ai-coding-config plugin, users following these instructions will get errors trying to install a non-existent plugin. The commands need updating to just /plugin install ai-coding-config.

Additional Locations (1)

• plugins/core/commands/ai-coding-config.md#L105-L106