Skip to content

sfm:blocks/buffer loot table references unregistered item sfm:buffer (ERROR on every boot) #583

Description

@TommyC81

Mod: Super Factory Manager 4.34.0 (Super Factory Manager (SFM)-MC1.21.1-4.34.0.jar, NeoForge 1.21.1)

Summary

SFM registers a buffer block and block entity but no corresponding item, yet ships a loot table for the block that drops sfm:buffer. The loot table fails to resolve on every load.

Error (server log)

[Worker-Main/ERROR] [net.minecraft.world.level.storage.loot.LootDataType/]: Couldn't parse element ResourceKey[minecraft:root / minecraft:loot_table]:sfm:blocks/buffer - Unknown registry key in ResourceKey[minecraft:root / minecraft:item]: sfm:buffer

Root cause

Inspecting SFM's own registration:

  • SFMBlocks.BUFFER_BLOCK (block) — registered ✓
  • SFMBlockEntities.BUFFER (block entity) — registered ✓
  • SFMItems — registers no BlockItem for buffer (only xp_shard, xp_goop, etc.) ✗

Yet the jar ships data/sfm/loot_tables/blocks/buffer.json referencing sfm:buffer as its drop. The item doesn't exist, so the loot table can't parse.

This looks like an incomplete/leftover feature — the block was registered (and the loot table authored) but the BlockItem registration was never added (or the buffer is intended to be non-obtainable and the loot table shouldn't exist).

Impact

None at runtime beyond the startup ERROR log line — the buffer block cannot normally be obtained/placed without an item form, so in practice no chest ever tries to drop it. Purely log noise. Reported mainly because it shows as a red ERROR on every boot and is trivially fixable.

Fix options

  1. Register a BufferBlockItem in SFMItems (if the buffer is meant to be obtainable), or
  2. Remove data/sfm/loot_tables/blocks/buffer.json from the jar (if it isn't).

Reproduction

Boot a NeoForge 1.21.1 server with SFM 4.34.0. The ERROR appears during loot-table load. No player action required.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcode healthTowards code that soothes the soul

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions