Skip to content

Project Viewed Event not to be sent for commits that were inherited from the original project on forking #1477

@jachro

Description

@jachro

It was observed that sending a Project Viewed Event for commits inherited from the parent project while forking is in most cases (if not all) not a good idea. The reason is that they get accounted for on behalf of the author of the commits (the parent project committer) and as a result, it will cause the fork project to be listed as a recently viewed project for the author. In the general case, this is not true as the author could not even know someone forked his project and for sure it might be the project he recently viewed.

Acceptance criteria:

  • Perhaps, we should check the push event author and skip sending an event if the push event author is not a member of the project;
  • It's also worth checking if GL can even provide us with a push event for the commits inherited from the parent project. If not, we should simply skip sending the event in case there's no push event for a commit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Ready

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions