[Crash] Spawning SmokeParticle manually causes a crash

[mchorse]

Hello!

I have a system in place where my mod can spawn particles from the registry. All of vanilla particles seem to be working correctly, however, spawning the net.superkat.explosiveenhancement.particles.SmokeParticle caused a crash. Here is the crash log:

crash-2024-12-30_18.29.49-client.txt

The ID of the particle is explosiveenhancement:sparks. Is it an issue coming from my mod, or from your mod? This is how I spawn the particle:

World world = entity.getWorld();
boolean paused = this.form.paused.get(0F);

if (world != null && !paused)
{
    float velocity = this.form.velocity.get(0F);
    int count = this.form.count.get(0F);
    int frequency = this.form.frequency.get(0F);

    if (this.tick <= 0)
    {
        Matrix3f m = Matrices.TEMP_3F;
        Vector3f v = Vectors.TEMP_3F;
        ParticleSettings settings = this.form.settings.get(0F);
        ParticleType type = Registries.PARTICLE_TYPE.get(settings.particle); // This is how I get the type
        ParticleEffect effect = ParticleTypes.FLAME;

        try
        {
            if (type != null)
            {
                effect = type.getParametersFactory().read(type, new StringReader(" " + settings.arguments)); // And this is how I get type with extra string parameters
            }
        }
        catch (Exception e)
        {}

        for (int i = 0; i < count; i++)
        {
            float velocityX = this.vel.x * velocity;
            float velocityY = this.vel.y * velocity;
            float velocityZ = this.vel.z * velocity;
            float sh = MathUtils.toRad(this.form.scatteringYaw.get(0F)) * (float) (Math.random() - 0.5D);
            float sv = MathUtils.toRad(this.form.scatteringPitch.get(0F)) * (float) (Math.random() - 0.5D);

            m.identity()
                .rotateY(sh)
                .rotateX(sv)
                .transform(v.set(velocityX, velocityY, velocityZ));

            double x = this.pos.x + ((Math.random() * 2F - 1F) * this.form.offsetX.get(0F));
            double y = this.pos.y + ((Math.random() * 2F - 1F) * this.form.offsetY.get(0F));
            double z = this.pos.z + ((Math.random() * 2F - 1F) * this.form.offsetZ.get(0F));

            world.addParticle(effect, true, x, y, z, v.x, v.y, v.z);
        }

        this.tick = frequency;
    }

    this.tick -= 1;
}

I'm not sure how exactly it could happen on my end, so it would be nice if you could point out what could I be doing wrong.

Thank you for attention, and Happy Holidays! 🎄🎉

[Superkat32]

Hiya! This is very likely on my end because I use most of my particle's velocity to determine the size ( probably related to #35 ). I didn't account for people spawning in my particles themselves though, so spawning in some of my particles in older Explosive Enhancement versions(1.2) with a velocity of 0 may cause a disconnection (or crash apparently ¯\(ツ)/¯ )

This should have been fixed with Explosive Enhancement 1.3. Try that and let me know how it works for you.

Beyond that, I really need to make it so that my particles have a custom parameter(like the sculk vibration particle) for the size instead of reusing the velocity. I was planning on doing that for 1.3, but doing so changes multiple times from Minecraft 1.19.2-1.21.4 which was really frustrating to implement, so I decided to just wait(I'm unsure how I'll approach this; it's very likely to happen one day, but maybe not for older Minecraft versions(anything other than latest) so don't bank on it).

If you find any other issues, or need me to make a hotfix on my end, you can do so here(or in a new issue if you feel like it needs it). Thanks!