Add column sorting to "Batch convert" file list view

Author: niksedk

libse/Utilities.cs

@@ -77,7 +77,7 @@ public static bool IsHex(string s)
 
         public static SubtitleFormat GetSubtitleFormatByFriendlyName(string friendlyName)
         {
-            foreach (SubtitleFormat format in SubtitleFormat.AllSubtitleFormats)
+            foreach (var format in SubtitleFormat.AllSubtitleFormats)
             {
                 if (format.FriendlyName == friendlyName || format.Name == friendlyName)
                 {
@@ -107,6 +107,43 @@ public static string FormatBytesToDisplayFileSize(long fileSize)
             return $"{(float)fileSize / (1024 * 1024 * 1024):0.0} gb";
         }
 
+        public static long DisplayFileSizeToBytes(string displayFileSize)
+        {
+            if (displayFileSize.Contains("bytes"))
+            {
+                if (double.TryParse(displayFileSize.Replace("bytes", string.Empty).Trim(), NumberStyles.AllowDecimalPoint, CultureInfo.CurrentCulture, out var n))
+                {
+                    return (int)Math.Round(n);
+                }
+            }
+
+            if (displayFileSize.Contains("kb"))
+            {
+                if (double.TryParse(displayFileSize.Replace("kb", string.Empty).Trim(), NumberStyles.AllowDecimalPoint, CultureInfo.CurrentCulture, out var n))
+                {
+                    return (int)Math.Round(n * 1024);
+                }
+            }
+
+            if (displayFileSize.Contains("mb"))
+            {
+                if (double.TryParse(displayFileSize.Replace("mb", string.Empty).Trim(), NumberStyles.AllowDecimalPoint, CultureInfo.CurrentCulture, out var n))
+                {
+                    return (int)Math.Round(n * 1024 * 1024);
+                }
+            }
+
+            if (displayFileSize.Contains("gb"))
+            {
+                if (double.TryParse(displayFileSize.Replace("gb", string.Empty).Trim(), NumberStyles.AllowDecimalPoint, CultureInfo.CurrentCulture, out var n))
+                {
+                    return (int)Math.Round(n * 1024 * 1024 * 1024);
+                }
+            }
+
+            return 0;
+        }
+
         /// <summary>
         /// Downloads the requested resource as a <see cref="String"/> using the configured <see cref="WebProxy"/>.
         /// </summary>

src/Forms/BatchConvert.Designer.cs

@@ -2436,5 +2436,38 @@ private void inverseSelectionToolStripMenuItem_Click(object sender, EventArgs e)
                 item.Checked = !item.Checked;
             }
         }
+
+        private void listViewInputFiles_ColumnClick(object sender, ColumnClickEventArgs e)
+        {
+            if (_converting)
+            {
+                return;
+            }
+
+            var sorter = (ListViewSorter)listViewInputFiles.ListViewItemSorter;
+            if (sorter == null)
+            {
+                sorter = new ListViewSorter
+                {
+                    ColumnNumber = e.Column, 
+                    IsNumber = false, 
+                    IsDisplayFileSize = e.Column == columnHeaderSize.DisplayIndex
+                };
+                listViewInputFiles.ListViewItemSorter = sorter;
+            }
+
+            if (e.Column == sorter.ColumnNumber)
+            {
+                sorter.Descending = !sorter.Descending; // inverse sort direction
+            }
+            else
+            {
+                sorter.ColumnNumber = e.Column;
+                sorter.Descending = false;
+                sorter.IsNumber = false;
+                sorter.IsDisplayFileSize = e.Column == columnHeaderSize.DisplayIndex;
+            }
+            listViewInputFiles.Sort();
+        }
     }
 }

src/Forms/BatchConvert.cs

@@ -1,36 +1,47 @@
 using System;
 using System.Windows.Forms;
+using Nikse.SubtitleEdit.Core;
 
 namespace Nikse.SubtitleEdit.Logic
 {
     public class ListViewSorter : System.Collections.IComparer
     {
+        public int ColumnNumber { get; set; }
+        public bool IsNumber { get; set; }
+        public bool IsDisplayFileSize { get; set; }
+        public bool Descending { get; set; }
+
         public int Compare(object o1, object o2)
         {
-            var lvi1 = o1 as ListViewItem;
-            var lvi2 = o2 as ListViewItem;
-            if (lvi1 == null || lvi2 == null)
+            if (!(o1 is ListViewItem lvi1) || !(o2 is ListViewItem lvi2))
             {
                 return 0;
             }
 
             if (Descending)
             {
-                ListViewItem temp = lvi1;
+                var temp = lvi1;
                 lvi1 = lvi2;
                 lvi2 = temp;
             }
 
             if (IsNumber)
             {
-                var i1 = int.Parse(lvi1.SubItems[ColumnNumber].Text);
-                var i2 = int.Parse(lvi2.SubItems[ColumnNumber].Text);
-                return (i1 > i2) ? 1 : (i1 == i2 ? 0 : -1);
+                if (int.TryParse(lvi1.SubItems[ColumnNumber].Text, out var i1) &&
+                    int.TryParse(lvi2.SubItems[ColumnNumber].Text, out var i2))
+                {
+                    return i1 > i2 ? 1 : i1 == i2 ? 0 : -1;
+                }
             }
+
+            if (IsDisplayFileSize)
+            {
+                var i1 = Utilities.DisplayFileSizeToBytes(lvi1.SubItems[ColumnNumber].Text);
+                var i2 = Utilities.DisplayFileSizeToBytes(lvi2.SubItems[ColumnNumber].Text);
+                return i1 > i2 ? 1 : i1 == i2 ? 0 : -1;
+            }
+
             return string.Compare(lvi2.SubItems[ColumnNumber].Text, lvi1.SubItems[ColumnNumber].Text, StringComparison.Ordinal);
         }
-        public int ColumnNumber { get; set; }
-        public bool IsNumber { get; set; }
-        public bool Descending { get; set; }
     }
 }