feat(bundle): downgrade to php82

Author: gilles-g

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - { php: 8.3, symfony: "6.4.*", composer-flags: '--prefer-dist' } # LTS with last stable PHP
+          - { php: 8.2, symfony: "6.4.*", composer-flags: '--prefer-dist' } # LTS with last stable PHP
           - { php: 8.3, symfony: "7.1.*", composer-flags: '--prefer-dist' } # Stable Symfony branches
           - { php: 8.4, symfony: "7.2.*", composer-flags: '--prefer-dist' } # Stable Symfony branches
 

composer.json

@@ -24,7 +24,7 @@
         }
     },
     "require": {
-        "php": ">=8.3",
+        "php": ">=8.2",
         "doctrine/orm": "3.* || ^4.0",
         "symfony/config": "^6.4|^7.0",
         "symfony/dependency-injection": "^6.4|^7.0",

rector.php

@@ -24,8 +24,8 @@
     ->withPaths([
         __DIR__
     ])
-    ->withPhpVersion(PhpVersion::PHP_83)
-    ->withSets([SetList::PHP_83])
+    ->withPhpVersion(PhpVersion::PHP_82)
+    ->withSets([SetList::PHP_82])
     ->withImportNames()
     ->withPreparedSets(
         deadCode: true,

src/Notification/MailerNotification.php

@@ -18,15 +18,15 @@
 use Symfony\Component\Mime\Address;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
-final class MailerNotification implements NotificationInterface
+final readonly class MailerNotification implements NotificationInterface
 {
     /**
      * @param mixed[] $addresses
      */
     public function __construct(
-        private readonly MailerInterface $mailer,
-        private readonly TranslatorInterface $translator,
-        private readonly array $addresses,
+        private MailerInterface $mailer,
+        private TranslatorInterface $translator,
+        private array $addresses,
     ) {
     }
 

tests/DependencyInjection/SpiriitAuthLogExtensionTest.php

@@ -62,7 +62,7 @@ private function createContainer(array $configs = []): ContainerBuilder
             ],
         ]));
 
-        $container->set('kernel', function () {
+        $container->set('kernel', function (): Kernel {
             return new Kernel('test', false);
         });
 

tests/Integration/KernelTest.php

@@ -23,8 +23,6 @@ class KernelTest extends KernelTestCase
 {
     protected function setUp(): void
     {
-        parent::setUp();
-
         $fs = new Filesystem();
         $fs->remove(sys_get_temp_dir().'/SpiriitAuthLogBundle/');
     }

tests/Integration/Stubs/BundleExtension.php

@@ -18,6 +18,6 @@ class BundleExtension extends Extension
 {
     public function load(array $configs, ContainerBuilder $container): void
     {
-        $phpLoader = new PhpFileLoader($container, new FileLocator(__DIR__.'/../config'));
+        new PhpFileLoader($container, new FileLocator(__DIR__.'/../config'));
     }
 }

tests/Integration/Stubs/Kernel.php

@@ -19,10 +19,7 @@ class Kernel extends BaseKernel
     /* @phpstan-ignore-next-line */
     public const IS_LEGACY = 5 > BaseKernel::MAJOR_VERSION;
 
-    /**
-     * @var string
-     */
-    private $config;
+    private string $config;
 
     public function __construct(string $environment, bool $debug, string $config = 'base')
     {

tests/Notification/MailerNotificationTest.php

@@ -36,7 +36,7 @@ public function testSend(): void
             ],
         );
 
-        $user = new class implements AuthenticableLogInterface {
+        new class implements AuthenticableLogInterface {
             public function getAuthenticationLogFactoryName(): string
             {
                 return 'user';