diff --git a/utils/dataset.py b/utils/dataset.py index 3975448..ceb3100 100644 --- a/utils/dataset.py +++ b/utils/dataset.py @@ -85,7 +85,26 @@ def download(self): filename = os.path.join(root, gz_filename) with tarfile.open(filename, 'r') as f: - f.extractall(root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, root) os.rename(BASEDIR + '/data/miniImageNet/mini-imagenet-cache-train.pkl', BASEDIR + '/data/miniImageNet/train') os.rename(BASEDIR + '/data/miniImageNet/mini-imagenet-cache-val.pkl', BASEDIR + '/data/miniImageNet/val')