SONARPY-3583 Set classmethod cls parameter to SelfType (#728)

GitOrigin-RevId: c66c9c45948a5b824e4b67b4883a4b2c8bf939c8

Author: Seppli11

python-checks/src/test/resources/checks/argumentNumber.py

@@ -102,7 +102,7 @@ def foo(): pass
         @classmethod
         def bar_class_method(cls):
             cls.bar_instance_method(cls)
-            cls.bar_instance_method(cls, 1) # FN
+            cls.bar_instance_method(cls, 1) # Noncompliant
         def bar_instance_method(self): pass
 
     A.class_meth(42) # FN {{'class_meth' expects 2 positional arguments, but 1 was provided}}

python-frontend/src/main/java/org/sonar/python/semantic/v2/types/TrivialTypeInferenceVisitor.java

@@ -460,10 +460,6 @@ private void setSelfParameterType(FunctionDef functionDef) {
       return;
     }
 
-    if (!functionType.isInstanceMethod()) {
-      return;
-    }
-
     var parameterList = functionDef.parameters();
     if (parameterList == null) {
       return;
@@ -476,10 +472,15 @@ private void setSelfParameterType(FunctionDef functionDef) {
 
     var firstParam = parameters.get(0);
     var paramName = firstParam.name();
-    // Set the type to ObjectType[SelfType[ClassType]]
-    if (paramName != null) {
-      var classObjectType = ObjectType.fromType(classType);
-      var selfType = SelfType.of(classObjectType);
+    if (paramName == null) {
+      return;
+    }
+
+    var selfType = SelfType.of(classType);
+    if (functionType.isInstanceMethod()) {
+      var selfObjectType = ObjectType.fromType(selfType);
+      setTypeToName(paramName, selfObjectType);
+    } else if (functionType.isClassMethod()) {
       setTypeToName(paramName, selfType);
     }
   }

python-frontend/src/test/java/org/sonar/python/semantic/v2/TypeInferenceV2Test.java

@@ -4204,10 +4204,9 @@ def foo(cls):
     var clsExpressionStatement = (ExpressionStatement) fooMethodDef.body().statements().get(0);
     var clsExpression = clsExpressionStatement.expressions().get(0);
 
-    assertThat(clsExpression.typeV2()).isNotInstanceOf(SelfType.class);
     assertThat(clsExpression.typeV2())
-      .extracting(PythonType::unwrappedType)
-      .isNotInstanceOf(SelfType.class);
+      .isInstanceOfSatisfying(SelfType.class, selfType -> assertThat(selfType.innerType())
+        .isEqualTo(classDef.name().typeV2()));
   }
 
   @Test