SONARPY-3592 Fix S930 related to TypeVar and type instances (#736)

GitOrigin-RevId: d86556f9005b4eb687c46a74bc1b75fe2ad0209c

Author: Seppli11

python-checks/src/main/java/org/sonar/python/checks/ArgumentNumberCheck.java

@@ -136,7 +136,9 @@ private static boolean isException(SubscriptionContext ctx, CallExpression callE
       || callExpression.arguments().stream().anyMatch(argument -> argument.is(Tree.Kind.UNPACKING_EXPR))
       || extendsZopeInterface(ctx, callExpression)
       || isCalledAsBoundInstanceMethod(callExpression)
-      || isSuperCall(ctx, callExpression);
+      || isSuperCall(ctx, callExpression)
+      || isReceiverTypeVar(ctx, callExpression)
+      || isReceiverTypeInstance(ctx, callExpression);
   }
 
   private static boolean extendsZopeInterface(SubscriptionContext ctx, CallExpression callExpression) {
@@ -153,6 +155,23 @@ private static boolean isCalledAsBoundInstanceMethod(CallExpression callExpressi
     return false;
   }
 
+  private static boolean isReceiverTypeVar(SubscriptionContext ctx, CallExpression callExpression) {
+    if (callExpression.callee() instanceof QualifiedExpression qualifiedExpression) {
+      return TypeMatchers.isObjectSatisfying(TypeMatchers.isOrExtendsType("typing.TypeVar"))
+        .isTrueFor(qualifiedExpression.qualifier(), ctx);
+    }
+    return false;
+  }
+
+  private static boolean isReceiverTypeInstance(SubscriptionContext ctx, CallExpression callExpression) {
+    // see SONARPY-3591
+    if (callExpression.callee() instanceof QualifiedExpression qualifiedExpression) {
+      return TypeMatchers.isObjectSatisfying(TypeMatchers.isOrExtendsType("type"))
+        .isTrueFor(qualifiedExpression.qualifier(), ctx);
+    }
+    return false;
+  }
+
   private static boolean isSuperCall(SubscriptionContext ctx, CallExpression callExpression) {
     if (callExpression.callee() instanceof QualifiedExpression qualifiedExpression) {
       return TypeMatchers.isObjectOfType("super").isTrueFor(qualifiedExpression.qualifier(), ctx);

python-checks/src/test/resources/checks/argumentNumber.py

@@ -193,6 +193,37 @@ def something(self, importing=None):
                 importing = set()
             importing.discard(1)
             importing.discard(1, 2) # FN
+
+def methods_on_types():
+    class Test: pass
+
+    sys_type = type(Test)
+    sys_type.__setattr__(sys, key,  "42") # Ok
+    sys_type.__setattr__(key, "42") # FN see SONARPY-3591
+
+    type.mro() # Noncompliant
+    type.mro(type) # Ok
+
+    sys_type.mro() # FN see SONARPY-3591
+    sys_type.mro(Test) # Ok
+
+    test_instance = Test()
+    test_instance_type = type(test_instance)
+    test_instance_type.mro() # Ok
+    test_instance_type.mro(test_instance) #  see SONARPY-3591
+
+
+    import typing
+    _T = typing.TypeVar('_T')
+
+    class GenericTest(typing.Generic[_T]):
+        cls: _T
+        def __new__(cls): 
+            pass
+
+        def test(self):
+            GenericTest.cls.__new__(self.cls) # Ok
+            GenericTest.cls.__new__(self.cls, 1) # FN
 
 
 def builtin_method():