-
Notifications
You must be signed in to change notification settings - Fork 406
SONAR-25652 Migrate to GitHub actions #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONAR-25652 Migrate to GitHub actions #719
Conversation
b3e1dd3 to
dc58c90
Compare
|
2ac9ec5 to
cbdc93b
Compare
e71201f to
2c954cb
Compare
c64713c to
46f6399
Compare
9ece729 to
01c85c2
Compare
|
carminevassallo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jCOTINEAU and @lukasz-jarocki-sonarsource, this is simply great!
Before accepting, I think we still need to define the required checks or an aggregator of them. Specifically, in the migrations of the repos belonging to our squad, we are trying to use the concept of qa-validator (see this example) to ensure that all the required checks are considered in the validation and we mark as required just the qa-validator task. Would it be possible to add it?
Also, I noticed we are not using the latest slack notification action. I'm fine with not having it added now, we will tackle it here: https://sonarsource.atlassian.net/browse/SONAR-26397.
|
thanks for the review, feel free to add |
Co-authored-by: Jérémy Cotineau <[email protected]>
01c85c2 to
0b37b86
Compare
6b7b6b8 to
3dd38d8
Compare
6fcb65a to
4adcc71
Compare
|
carminevassallo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just added the missing qa-validator (which is now required) and fixed the quality-gate issues.





SONAR-25760
below comment is by @lukasz-jarocki-sonarsource :
Build and push to Azure and Google Cloud Platform were validated before moving this pull request to "in review".
I couldn't find out how we often/when we run Azure push to staging on Cirrus, so for now I keep it only as workflow dispatch.