Skip to content

Conversation

@jCOTINEAU
Copy link
Contributor

@jCOTINEAU jCOTINEAU commented Sep 3, 2025

SONAR-25760

below comment is by @lukasz-jarocki-sonarsource :
Build and push to Azure and Google Cloud Platform were validated before moving this pull request to "in review".

I couldn't find out how we often/when we run Azure push to staging on Cirrus, so for now I keep it only as workflow dispatch.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title DRAFT: Tasks/jc/sonar 25652 migrate to GitHub actions SONAR-25760 DRAFT: Tasks/jc/sonar 25652 migrate to GitHub actions Sep 3, 2025
@jCOTINEAU jCOTINEAU force-pushed the tasks/jc/SONAR-25652-migrate-to-github-actions branch 3 times, most recently from b3e1dd3 to dc58c90 Compare September 3, 2025 15:58
@sonarqube-next
Copy link

sonarqube-next bot commented Sep 3, 2025

@jCOTINEAU jCOTINEAU changed the title SONAR-25760 DRAFT: Tasks/jc/sonar 25652 migrate to GitHub actions SONAR-25652 DRAFT: Tasks/jc/sonar 25652 migrate to GitHub actions Sep 5, 2025
@jCOTINEAU jCOTINEAU force-pushed the tasks/jc/SONAR-25652-migrate-to-github-actions branch 7 times, most recently from 2ac9ec5 to cbdc93b Compare October 8, 2025 14:11
@jCOTINEAU jCOTINEAU changed the title SONAR-25652 DRAFT: Tasks/jc/sonar 25652 migrate to GitHub actions DRAFT SONAR-25652 Tasks/jc/sonar 25652 migrate to GitHub actions Oct 15, 2025
@jCOTINEAU jCOTINEAU marked this pull request as draft October 15, 2025 12:11
@lukasz-jarocki-sonarsource lukasz-jarocki-sonarsource force-pushed the tasks/jc/SONAR-25652-migrate-to-github-actions branch 5 times, most recently from e71201f to 2c954cb Compare November 18, 2025 09:13
@lukasz-jarocki-sonarsource lukasz-jarocki-sonarsource changed the title DRAFT SONAR-25652 Tasks/jc/sonar 25652 migrate to GitHub actions SONAR-25652 Tasks/jc/sonar 25652 migrate to GitHub actions Nov 18, 2025
@lukasz-jarocki-sonarsource lukasz-jarocki-sonarsource force-pushed the tasks/jc/SONAR-25652-migrate-to-github-actions branch 6 times, most recently from c64713c to 46f6399 Compare November 20, 2025 10:31
@SonarSource SonarSource deleted a comment from sonarqube-next bot Nov 20, 2025
@lukasz-jarocki-sonarsource lukasz-jarocki-sonarsource marked this pull request as ready for review November 20, 2025 10:41
@lukasz-jarocki-sonarsource lukasz-jarocki-sonarsource force-pushed the tasks/jc/SONAR-25652-migrate-to-github-actions branch from 9ece729 to 01c85c2 Compare November 20, 2025 12:27
@sonarqube-next
Copy link

@lukasz-jarocki-sonarsource lukasz-jarocki-sonarsource changed the title SONAR-25652 Tasks/jc/sonar 25652 migrate to GitHub actions SONAR-25652 Migrate to GitHub actions Nov 20, 2025
Copy link
Collaborator

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jCOTINEAU and @lukasz-jarocki-sonarsource, this is simply great!

Before accepting, I think we still need to define the required checks or an aggregator of them. Specifically, in the migrations of the repos belonging to our squad, we are trying to use the concept of qa-validator (see this example) to ensure that all the required checks are considered in the validation and we mark as required just the qa-validator task. Would it be possible to add it?

Also, I noticed we are not using the latest slack notification action. I'm fine with not having it added now, we will tackle it here: https://sonarsource.atlassian.net/browse/SONAR-26397.

@lukasz-jarocki-sonarsource
Copy link
Member

thanks for the review, feel free to add qa-validator, in case you won't have time for it I will take a look at it later this week :)

@carminevassallo carminevassallo force-pushed the tasks/jc/SONAR-25652-migrate-to-github-actions branch from 01c85c2 to 0b37b86 Compare November 28, 2025 11:26
@carminevassallo carminevassallo force-pushed the tasks/jc/SONAR-25652-migrate-to-github-actions branch from 6b7b6b8 to 3dd38d8 Compare November 28, 2025 11:42
@carminevassallo carminevassallo force-pushed the tasks/jc/SONAR-25652-migrate-to-github-actions branch from 6fcb65a to 4adcc71 Compare November 28, 2025 12:03
@sonarqube-next
Copy link

sonarqube-next bot commented Nov 28, 2025

Copy link
Collaborator

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just added the missing qa-validator (which is now required) and fixed the quality-gate issues.

@carminevassallo carminevassallo merged commit 5902e74 into master Nov 28, 2025
18 checks passed
@carminevassallo carminevassallo deleted the tasks/jc/SONAR-25652-migrate-to-github-actions branch November 28, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants