Skip to content

Invalid UVL files #3

Description

@h3ssto

According to featjar, the following files of the benchmark are not valid UVL:

Double-quoted string attribute value

A feature carries a string-valued attribute written with double quotes, e.g.,
{featureDescription__ "..."}. Per the UVL language-levels paper a string
value must be single-quoted ('...'); "..." is identifier syntax.

Minimal: A {description "x"} fails; A {description 'x'} is accepted.

./feature_models/uvl/automotive/automotive01/Kowal2016.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2017-05-22.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2017-09-28.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2017-10-20.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2017-11-20.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2017-12-22.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2018-01-23.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2018-02-20.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2018-03-26.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2018-04-23.uvl
./feature_models/uvl/finance/FinancialServices01/Nieke2018-2018-05-09.uvl

Feature named Type

Type is a reserved keyword in the grammar
(mismatched input 'Type' expecting {'String','Integer','Real','Boolean',ID_NOT_STRICT,ID_STRICT}).

./feature_models/uvl/e_commerce/e_shop/Lau2006.uvl

Single quote inside a double-quoted feature name

A feature whose name is a double-quoted identifier containing a ', e.g.,
"Compare-Name-'CONFIG_BOARD_NAME'-,". featjar parses the declaration
and the constraint reference to different strings, then fails the
cross-reference check:
Feature "..." is referenced in a constraint ... but does not exist as feature in the tree!

Minimal: feature "a'b" used in a constraint

./feature_models/uvl/systems_software/soletta/Pett2023-2016-05-25_19-04-11.uvl

Line 21: "Compare-Name-'CONFIG_BOARD_NAME'-,"

./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-07_14-12-02.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-07_14-19-55.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-13_14-56-51.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-14_11-06-45.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-17_16-06-07.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-27_14-59-46.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-27_15-09-30.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-28_13-27-17.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-06-28_17-43-56.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-07-01_15-00-13.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-07-19_18-32-56.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-07-22_09-19-36.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-08-16_16-45-48.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-10-31_22-17-41.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-11-01_10-03-33.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-11-04_20-52-57.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2016-11-22_03-38-15.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2017-03-01_15-25-44.uvl
./feature_models/uvl/systems_software/soletta/Pett2023-2017-03-09_21-02-40.uvl


See also FeatureIDE/FeatJAR#13

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions