fix(Autoscout): expired listings produce gigantic error messages

Author: SIMULATAN

integration/autoscout/build.gradle.kts

@@ -1 +1 @@
-version = "0.1.0"
+version = "0.1.1"

integration/autoscout/src/main/kotlin/me/snoty/integration/contrib/autoscout/api/AutoscoutAPI.kt

@@ -1,7 +1,9 @@
 package me.snoty.integration.contrib.autoscout.api
 
+import io.github.oshai.kotlinlogging.KotlinLogging
 import io.ktor.client.*
 import io.ktor.client.request.*
+import io.ktor.http.*
 import kotlinx.serialization.json.Json
 import kotlinx.serialization.json.jsonObject
 import me.snoty.integration.contrib.autoscout.model.AutoscoutListing
@@ -16,11 +18,40 @@ interface AutoscoutAPI {
 }
 
 @Single
-class AutoscoutAPIImpl(private val httpClient: HttpClient, private val json: Json) : AutoscoutAPI, KoinComponent {
+class AutoscoutAPIImpl(httpClient: HttpClient, private val json: Json) : AutoscoutAPI, KoinComponent {
+	private val noRedirectClient = httpClient.config {
+		followRedirects = false
+		// failures are handled explicitly
+		expectSuccess = false
+	}
+
+	val logger = KotlinLogging.logger {}
+
 	override suspend fun fetchListing(url: String): AutoscoutListing? {
 		val mappedUrl = parseAutoscoutUrl(url)
 
-		val response = httpClient.get(mappedUrl)
+		val response = noRedirectClient.get(mappedUrl)
+
+		fun logListingExpired() {
+			logger.warn { "Listing $url is expired" }
+		}
+
+		when (response.status) {
+			HttpStatusCode.MovedPermanently -> {
+				val location = response.headers[HttpHeaders.Location] ?: throw IllegalArgumentException("Redirect without a Location")
+				if (location.startsWith("/lst/")) {
+					logListingExpired()
+					return null
+				}
+				throw IllegalArgumentException("Invalid redirect location: $location")
+			}
+			HttpStatusCode.NotFound, HttpStatusCode.Gone -> {
+				logListingExpired()
+				return null
+			}
+			HttpStatusCode.OK -> Unit
+			else -> throw IllegalArgumentException("Invalid response status: ${response.status}")
+		}
 
 		val props = response.parseNextPageProps(json)
 		val advertDetails = props.getOrThrow("listingDetails").jsonObject