Fix duplicate UID and delete orphaned bindings, fixes #255

Author: Snakybo

CHANGELOG.md

@@ -39,6 +39,7 @@ The format of this changelog is based on [Keep a Changelog](https://keepachangel
 * Fix deleted bindings not being deactivated immediately
 * Fix a potential data conflict issue when importing a profile [#252] (by [m33shoq])
 * Fix logic error [#270] (by [KyrosKrane])
+* Fix duplicate binding IDs [#255]
 
 ## [1.16.11] - 2024-11-07
 
@@ -1750,6 +1751,7 @@ The format of this changelog is based on [Keep a Changelog](https://keepachangel
 [#264]: https://github.com/Snakybo/Clicked/pull/264
 [#263]: https://github.com/Snakybo/Clicked/issues/263
 [#257]: https://github.com/Snakybo/Clicked/issues/257
+[#255]: https://github.com/Snakybo/Clicked/issues/255
 [#252]: https://github.com/Snakybo/Clicked/pull/252
 [#251]: https://github.com/Snakybo/Clicked/issues/251
 [#248]: https://github.com/Snakybo/Clicked/issues/248

Clicked/Core/Upgrader.lua

@@ -5,6 +5,8 @@ local Addon = select(2, ...)
 
 Addon.DATA_VERSION = 12
 
+local upgradeData = {}
+
 -- Local support functions
 
 local function errorhandler(err)
@@ -890,6 +892,37 @@ local function Upgrade(db, from)
 			binding.action.stopSpellTarget = true
 		end
 	end
+
+	if from < 13 then
+		upgradeData[13] = upgradeData[13] or {}
+		upgradeData[13].seen = upgradeData[13].seen or {}
+
+		local orphans = {}
+
+		for i, binding in ipairs(db.bindings) do
+			local function HasParent(group)
+				return binding.parent == group.uid
+			end
+
+			if upgradeData[13].seen[binding.uid] then
+				if binding.parent == nil or FindInTableIf(db.groups, HasParent) then
+					binding.uid = Addon.db.global.nextUid
+					Addon.db.global.nextUid = binding.uid + 1
+				else
+					table.insert(orphans, i)
+				end
+			elseif binding.parent ~= nil and not FindInTableIf(db.groups, HasParent) then
+				binding.parent = nil
+			end
+
+			upgradeData[13].seen[binding.uid] = true
+		end
+
+		table.sort(orphans, function(a, b) return a > b end)
+		for _, i in ipairs(orphans) do
+			table.remove(db.bindings, i)
+		end
+	end
 end
 
 -- Private addon API
@@ -909,6 +942,8 @@ function Addon:UpgradeDatabase(from)
 	-- when the value of a constant changes. Always use direct values that are
 	-- read from the database.
 
+	table.wipe(upgradeData)
+
 	if not Addon.DISABLE_GLOBAL_SCOPE then
 		local src = from or Addon.db.global.version or Addon.DATA_VERSION