Skip to content

Rules Refactor Part 2: Migrate career rules to use has_skill helper #16

@coderabbitai

Description

@coderabbitai

Context

Follow-up to PR #14 (Rules Refactor Part 1) which migrated aspiration rules to use events and the has_skill helper function.

The career rules should be similarly refactored to use the has_skill helper for consistency and maintainability.

Tasks

  • Refactor all career rule functions to use the has_skill helper instead of state.has() directly
  • Review and address related TODOs in the career logic:
  • Test to ensure no regressions

Reference

Example

See the aspiration rules in Rules.py (functions like _bodybuilder, _painter_extraordinaire, etc.) for examples of the pattern to follow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions