forked from ArchipelagoMW/Archipelago
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Context
Follow-up to PR #14 (Rules Refactor Part 1) which migrated aspiration rules to use events and the has_skill helper function.
The career rules should be similarly refactored to use the has_skill helper for consistency and maintainability.
Tasks
- Refactor all career rule functions to use the
has_skillhelper instead ofstate.has()directly - Review and address related TODOs in the career logic:
Rules.py:22- TODO: Part Time Jobs?Rules.py:719- TODO check project manager career logic (Discord: https://discord.com/channels/731205301247803413/1079002955262480424/1403764728177758252)Rules.py:799- TODO relearn how the career locations send, and then refactor this to use has_skill
- Test to ensure no regressions
Reference
- PR Sims 4: Rules Refactor Part 1 #14: Sims 4: Rules Refactor Part 1 #14
- Requested by: @benny-dreamly
Example
See the aspiration rules in Rules.py (functions like _bodybuilder, _painter_extraordinaire, etc.) for examples of the pattern to follow.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels