Skip to content

Bug in examples/chain_counter.cpp #762

@smr547

Description

@smr547

Call to the DigitalInputChange constructor (line 97) passes delay_time instead of interrupt_type as third parameter. Compiler silently casts the parameter but the button will not work.

API comments

Regarding DigitalInputChange:

  • interrupt_type seems redundant given the Class semantics implies only a CHANGE interrupt is applicable
  • Likewise config_path is unnecessary as there are no configurable parameters

I'm new to SensESP so my comments may be off the mark. Thank you for an outstanding project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions