[Theme Check] Allow visible_if on all input types

[andershagbard]

Allow visible_if to be used on all types.

I know that Shopify are explicitly listed the types this property is available on, but reality seems to be that this is supported on all types.

I personally use it on product_list and collection types.

I think the use case is obvious.

ValidSchema is the check that fails.

Example code:

{
  "type": "collection",
  "id": "collection",
  "label": "Collection",
  "visible_if": "{{ block.settings.source_type == 'collection' }}"
},
{
  "type": "product_list",
  "id": "list",
  "label": "Products",
  "visible_if": "{{ block.settings.source_type == 'list' }}"
}

[graygilmore]

Thanks @andershagbard! We won't be addressing this in the short term but will consider enhancing visible_if in the future. For the time being please refer to this list of settings that can make use of visible_if: https://shopify.dev/docs/storefronts/themes/architecture/settings#conditional-settings

[andershagbard]

My issue is not that visible_if is not useable on these types. It's that visible_if IS useable on these types, and the linter fails it

[graygilmore]

Ah, I see what you mean! The check should be equal to what we support. I'll double check that we're following the same list.

[andershagbard]

You are probably following the list from conditional settings, but that list seems to be wrong. A lot more types are supported

[dgpalmer]

You are probably following the list from conditional settings, but that list seems to be wrong. A lot more types are supported

Thank you for confirming my suspicions. I had been working on a new feature that uses visible_if conditions on a product setting, and it was working fine with shopify theme serve but the moment i ran a shopify theme check, it was saying the schema was invalid.

The thing is, the conditional visible_if on the product setting worked as intended in the theme editor, so it is supported, but theme check thinks its not. For now, I am ignoring that section in the ValidSchema portion of my theme check config but that's certainly not ideal, i would prefer to know about other schema issues in that section that are actually valid.

[andershagbard]

Shopify recently changed this to cause a server error when uploading the files to the theme. Theme check is now consistent with Shopify themes.

I don't agree with this change, as it was a breaking change, but the tool is doing the correct thing now at least 😄