Skip to content

Can't rename LiquidDoc param when cursor is at the first character of the var name #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charlespwd opened this issue May 6, 2025 · 0 comments
Labels
Bug Something isn't working SEV-3 Normal Severity

Comments

@charlespwd
Copy link
Contributor

Describe the bug
F2 when the cursor is at the beginning of the param name shows "you can't rename this thing". Wondering if that's because of the same findCurentNode thing that I fixed last week.

Source

{% doc %}
  @param {collection} █collection - The collection object to display.
{% enddoc %}

Expected behaviour
Can rename the thing. (Works if the cursor is 1 to the right of it, e.g. c█ollection

Actual behaviour
The element can't be renamed.

Debugging information

  • OS [e.g. Windows, Mac, Linux]
  • OS Version
  • Theme Check Version [e.g. 0.1.0]

Additional context
Add any other context about the problem here.

@charlespwd charlespwd added the Bug Something isn't working label May 6, 2025
@mgmanzella mgmanzella added the SEV-3 Normal Severity label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SEV-3 Normal Severity
Projects
None yet
Development

No branches or pull requests

2 participants