Removed CLOSURE_ORIGINAL_NAME property (#1829)

For: ShiftLeftSecurity/codescience#8347

Author: max-leuthaeuser

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/GraphSchema.scala

@@ -44,11 +44,6 @@ object PropertyNames {
     */
   val ClosureBindingId: String = "CLOSURE_BINDING_ID"
 
-  /** Deprecated. Create an explict REF edge instead. Formerly the original name of the (potentially mangled) captured
-    * variable
-    */
-  val ClosureOriginalName: String = "CLOSURE_ORIGINAL_NAME"
-
   /** This field holds the code snippet that the node represents. */
   val Code: String = "CODE"
 
@@ -295,7 +290,6 @@ object PropertyNames {
       AstParentType,
       CanonicalName,
       ClosureBindingId,
-      ClosureOriginalName,
       Code,
       ColumnNumber,
       ColumnNumberEnd,

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/Properties.scala

@@ -139,11 +139,6 @@ trait HasCanonicalNameEMT
   */
 trait HasClosureBindingIdEMT
 
-/** Node types with this marker trait are guaranteed to have the CLOSURE_ORIGINAL_NAME property. EMT stands for: "erased
-  * marker trait", it exists only at compile time in order to improve type safety.
-  */
-trait HasClosureOriginalNameEMT
-
 /** Node types with this marker trait are guaranteed to have the CODE property. EMT stands for: "erased marker trait",
   * it exists only at compile time in order to improve type safety.
   */

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/PropertyNames.scala

@@ -7,19 +7,14 @@ import scala.collection.mutable
 /** Node base type for compiletime-only checks to improve type safety. EMT stands for: "erased marker trait", i.e. it is
   * erased at runtime
   */
-trait ClosureBindingEMT
-    extends AnyRef
-    with HasClosureBindingIdEMT
-    with HasClosureOriginalNameEMT
-    with HasEvaluationStrategyEMT
+trait ClosureBindingEMT extends AnyRef with HasClosureBindingIdEMT with HasEvaluationStrategyEMT
 
 trait ClosureBindingBase extends AbstractNode with StaticType[ClosureBindingEMT] {
 
   override def propertiesMap: java.util.Map[String, Any] = {
     import io.shiftleft.codepropertygraph.generated.accessors.languagebootstrap.*
     val res = new java.util.HashMap[String, Any]()
     this.closureBindingId.foreach { p => res.put("CLOSURE_BINDING_ID", p) }
-    this.closureOriginalName.foreach { p => res.put("CLOSURE_ORIGINAL_NAME", p) }
     if (("<empty>": String) != this.evaluationStrategy) res.put("EVALUATION_STRATEGY", this.evaluationStrategy)
     res
   }
@@ -34,9 +29,6 @@ object ClosureBinding {
   * ▸ ClosureBindingId (String); Cardinality `ZeroOrOne` (optional); Identifier which uniquely describes a
   * CLOSURE_BINDING. This property is used to match captured LOCAL nodes with the corresponding CLOSURE_BINDING nodes
   *
-  * ▸ ClosureOriginalName (String); Cardinality `ZeroOrOne` (optional); Deprecated. Create an explict REF edge instead.
-  * Formerly the original name of the (potentially mangled) captured variable
-  *
   * ▸ EvaluationStrategy (String); Cardinality `one` (mandatory with default value `<empty>`); For formal method input
   * parameters, output parameters, and return parameters, this field holds the evaluation strategy, which is one of the
   * following: 1) `BY_REFERENCE` indicates that the parameter is passed by reference, 2) `BY_VALUE` indicates that it is
@@ -51,21 +43,19 @@ class ClosureBinding(graph_4762: flatgraph.Graph, seq_4762: Int)
   override def productElementName(n: Int): String =
     n match {
       case 0 => "closureBindingId"
-      case 1 => "closureOriginalName"
-      case 2 => "evaluationStrategy"
+      case 1 => "evaluationStrategy"
       case _ => ""
     }
 
   override def productElement(n: Int): Any =
     n match {
       case 0 => this.closureBindingId
-      case 1 => this.closureOriginalName
-      case 2 => this.evaluationStrategy
+      case 1 => this.evaluationStrategy
       case _ => null
     }
 
   override def productPrefix = "ClosureBinding"
-  override def productArity  = 3
+  override def productArity  = 2
 
   override def canEqual(that: Any): Boolean = that != null && that.isInstanceOf[ClosureBinding]
 }

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/accessors/Accessors.scala

@@ -44,9 +44,9 @@ class Finding(graph_4762: flatgraph.Graph, seq_4762: Int)
     with FindingBase
     with StaticType[FindingEMT] {
   def evidence: IndexedSeq[StoredNode] =
-    flatgraph.Accessors.getNodePropertyMulti[StoredNode](graph, nodeKind = nodeKind, propertyKind = 51, seq = seq)
+    flatgraph.Accessors.getNodePropertyMulti[StoredNode](graph, nodeKind = nodeKind, propertyKind = 50, seq = seq)
   def keyValuePairs: IndexedSeq[KeyValuePair] =
-    flatgraph.Accessors.getNodePropertyMulti[KeyValuePair](graph, nodeKind = nodeKind, propertyKind = 52, seq = seq)
+    flatgraph.Accessors.getNodePropertyMulti[KeyValuePair](graph, nodeKind = nodeKind, propertyKind = 51, seq = seq)
 
   override def productElementName(n: Int): String =
     n match {

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/nodes/BaseTypes.scala

@@ -1553,14 +1553,14 @@ class NewAnnotation extends NewNode(nodeKind = 0) with AnnotationBase with Expre
   override def countAndVisitProperties(interface: flatgraph.BatchedUpdateInterface): Unit = {
     interface.countProperty(this, 1, 1)
     interface.countProperty(this, 2, argumentName.size)
-    interface.countProperty(this, 8, 1)
-    interface.countProperty(this, 9, columnNumber.size)
-    interface.countProperty(this, 21, 1)
-    interface.countProperty(this, 34, lineNumber.size)
-    interface.countProperty(this, 38, 1)
-    interface.countProperty(this, 39, offset.size)
-    interface.countProperty(this, 40, offsetEnd.size)
-    interface.countProperty(this, 41, 1)
+    interface.countProperty(this, 7, 1)
+    interface.countProperty(this, 8, columnNumber.size)
+    interface.countProperty(this, 20, 1)
+    interface.countProperty(this, 33, lineNumber.size)
+    interface.countProperty(this, 37, 1)
+    interface.countProperty(this, 38, offset.size)
+    interface.countProperty(this, 39, offsetEnd.size)
+    interface.countProperty(this, 40, 1)
   }
 
   override def copy: this.type = {

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/nodes/ClosureBinding.scala

@@ -1526,13 +1526,13 @@ class NewAnnotationLiteral extends NewNode(nodeKind = 1) with AnnotationLiteralB
   override def countAndVisitProperties(interface: flatgraph.BatchedUpdateInterface): Unit = {
     interface.countProperty(this, 1, 1)
     interface.countProperty(this, 2, argumentName.size)
-    interface.countProperty(this, 8, 1)
-    interface.countProperty(this, 9, columnNumber.size)
-    interface.countProperty(this, 34, lineNumber.size)
-    interface.countProperty(this, 38, 1)
-    interface.countProperty(this, 39, offset.size)
-    interface.countProperty(this, 40, offsetEnd.size)
-    interface.countProperty(this, 41, 1)
+    interface.countProperty(this, 7, 1)
+    interface.countProperty(this, 8, columnNumber.size)
+    interface.countProperty(this, 33, lineNumber.size)
+    interface.countProperty(this, 37, 1)
+    interface.countProperty(this, 38, offset.size)
+    interface.countProperty(this, 39, offsetEnd.size)
+    interface.countProperty(this, 40, 1)
   }
 
   override def copy: this.type = {

domainClasses/src/main/generated/io/shiftleft/codepropertygraph/generated/nodes/Finding.scala

@@ -1438,12 +1438,12 @@ class NewAnnotationParameter extends NewNode(nodeKind = 2) with AnnotationParame
   def offsetEnd(value: Option[Int]): this.type    = { this.offsetEnd = value; this }
   def order(value: Int): this.type                = { this.order = value; this }
   override def countAndVisitProperties(interface: flatgraph.BatchedUpdateInterface): Unit = {
-    interface.countProperty(this, 8, 1)
-    interface.countProperty(this, 9, columnNumber.size)
-    interface.countProperty(this, 34, lineNumber.size)
-    interface.countProperty(this, 39, offset.size)
-    interface.countProperty(this, 40, offsetEnd.size)
-    interface.countProperty(this, 41, 1)
+    interface.countProperty(this, 7, 1)
+    interface.countProperty(this, 8, columnNumber.size)
+    interface.countProperty(this, 33, lineNumber.size)
+    interface.countProperty(this, 38, offset.size)
+    interface.countProperty(this, 39, offsetEnd.size)
+    interface.countProperty(this, 40, 1)
   }
 
   override def copy: this.type = {