[Request] Support selecting the language of text that is being looking for

[scillidan]

Dude, it's a simple and easy-to-use web application!

And I use a yomichan/yomitan dictionary other than Japanese, such as English, it cannot select words well.

Can you consider adding a new feature in the future to support selecting the language of text that is being looking for.

[ShaddyDC]

Glad you're liking the app!

Unfortunately, I think yomitan has gotten significantly more sophisticated in how it handles languages since the yomichan days, with multiple features to support different languages. Supporting them and any future upstream developments seems non-trivial.

On a high level, I see two approaches to tackling this:

1. Port all the features to yomi-dict, which this app uses. It's a lot of work, but it would be really nice in making them more accessible to other apps that may ever want to make use of them.
2. Somehow embed the corresponding yomitan logic in this app. It's js, so it might be possible to just inline it and run when interacting with the website. It will still require significant efforts to refactor everything here and make it work in the different context and how dictionary are stored in the db etc, but it would be much simpler to stay on top of updates.

Both of these approaches require a lot of effort, and I don't think I currently have the time or motivation to work on that, partly because I haven't been using Yomi-Reader myself in years nor done any work on it, sorry :(
I'd be happy to help out and advise in any efforts on this though and am happy to take contributions!

[scillidan]

Thank you for your detailed reply. It gave me some understanding of the complexity of this matter and provided some useful guidance.

I think I should try modify from this tool first🤔.

I recalled that some Chrome extensions support directly copying selected text, so I should try combining that with Yomitan's automatic clipboard reading feature🤔.

Yomitan's word segmentation function for languages is something I want to learn more about. So I might try to read through library Yomi-Reader, although I am a beginner and don't know Rust, I will seek help from GPT code master. Or Yomitan library.

Have a nice day!

[ShaddyDC]

Note that Yomi-Reader only supports the Japanese-specific stuff, since that was what yomichan originally supported. If you want the full current feature set, you should study yomitan.

Best of luck in your efforts! :)