bug: Allowing empty units for various command line options

vonericsen · vonericsen · commit 6c71e0763171 · 2025-04-25T10:15:11.000-06:00
Many options do not require a unit of measure to be provided but the low-level code was requiring it. This fixes it so that a unit is not required and allows a utility to choose when a unit is required or what the default behavior should be when the units are empty. [#181] Signed-off-by: Tyler Erickson <tyler.erickson@seagate.com>
diff --git a/subprojects/opensea-common b/subprojects/opensea-common
@@ -1 +1 @@
-Subproject commit 4bba3833915d476114ba62d8425e6f0a216bad4a
+Subproject commit 7d25ac3ccbb5a8bf5f86404ec2cd024a12339ea0
diff --git a/utils/C/openSeaChest/openSeaChest_Configure.c b/utils/C/openSeaChest/openSeaChest_Configure.c
@@ -566,7 +566,7 @@ int main(int argc, char* argv[])
                         // first check is a unit is provided.
                         if (unit)
                         {
-                            if (strcmp(unit, "ms") == 0)
+                            if (strcmp(unit, "ms") == 0 || strcmp(unit, "") == 0)
                             {
                                 multiplier = UINT32_C(1);
                             }
@@ -618,7 +618,7 @@ int main(int argc, char* argv[])
                         // first check is a unit is provided.
                         if (unit)
                         {
-                            if (strcmp(unit, "ms") == 0)
+                            if (strcmp(unit, "ms") == 0 || strcmp(unit, "") == 0)
                             {
                                 multiplier = UINT32_C(1);
                             }

Original file line number	Diff line number	Diff line change
`@@ -566,7 +566,7 @@ int main(int argc, char* argv[])`
`566`	`566`	`// first check is a unit is provided.`
`567`	`567`	`if (unit)`
`568`	`568`	`{`
`569`		`- if (strcmp(unit, "ms") == 0)`
	`569`	`+ if (strcmp(unit, "ms") == 0 \|\| strcmp(unit, "") == 0)`
`570`	`570`	`{`
`571`	`571`	`multiplier = UINT32_C(1);`
`572`	`572`	`}`
`@@ -618,7 +618,7 @@ int main(int argc, char* argv[])`
`618`	`618`	`// first check is a unit is provided.`
`619`	`619`	`if (unit)`
`620`	`620`	`{`
`621`		`- if (strcmp(unit, "ms") == 0)`
	`621`	`+ if (strcmp(unit, "ms") == 0 \|\| strcmp(unit, "") == 0)`
`622`	`622`	`{`
`623`	`623`	`multiplier = UINT32_C(1);`
`624`	`624`	`}`