feat: Finish solaris_ci_build_changes

Pulling in the changes made in meson build files to solve the solaris linking issues.
the stack protector option in GCC was not working as expected with solaris, but worked in illumos.
The solution was to disable it for solaris and leave it for illumos. This seems to be working and errors on the side of not using it purely for compatibility purposes.
It needs meson 1.2.0 or higher to properly detect the difference between the systems, but the way it is written preserves compatibility with older versions

Author: vonericsen

.github/workflows/vmactions.yml

@@ -30,28 +30,28 @@ jobs:
 
 # builds but fails to link due to __stack_chk_fail and __stack_chk_guard being undefined.
 # TODO: Figure out which flags to change in meson build scripts to resolve this. use .kernel() == solaris vs .kernel() == illumos
-#   solaris:
-#     runs-on: ubuntu-latest
-#     name: Build openSeaChest for Solaris
-#     steps:
-#     - uses: actions/checkout@v4
-#       with:
-#         submodules: recursive
-#     - name: Build openSeaChest for Solaris
-#       id: sol
-#       uses: vmactions/solaris-vm@v1
-#       with:
-#         release: "11.4-gcc"
-#         usesh: true
-#         prepare: |
-#           pkgutil -y -i socat
+  solaris:
+    runs-on: ubuntu-latest
+    name: Build openSeaChest for Solaris
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        submodules: recursive
+    - name: Build openSeaChest for Solaris
+      id: sol
+      uses: vmactions/solaris-vm@v1
+      with:
+        release: "11.4-gcc"
+        usesh: true
+        prepare: |
+          pkgutil -y -i socat
 
-#         run: |
-#           pkg update
-#           pkg install developer/build/meson
+        run: |
+          pkg update
+          pkg install developer/build/meson
 
-#           meson setup build -Dprefix=/ -Dmandir=/man -Dbindir=/ --buildtype=release
-#           meson install -C build
+          meson setup build -Dprefix=/ -Dmandir=/man -Dbindir=/ --buildtype=release
+          meson install -C build
 
   freebsd:
     runs-on: ubuntu-latest

meson.build

@@ -44,7 +44,6 @@ if c.get_id().contains('gcc') or c.get_id().contains('clang')
   '-Wimplicit-fallthrough',
   '-D_GLIBCXX_ASSERTIONS',
   '-fstrict-flex-arrays=1', #NOTE: Using level 1 since Windows often uses [1] at the end of it's structures. opensea-*libs has used this in a few places too.
-  '-fstack-protector-strong',
   '-fno-delete-null-pointer-checks',
   '-fno-strict-overflow',
   '-fno-strict-aliasing',
@@ -83,6 +82,19 @@ if c.get_id().contains('gcc') or c.get_id().contains('clang')
     warning_flags += '-Wsign-conversion'
   endif
 
+  if target_machine.system() != 'sunos'
+    warning_flags += '-fstack-protector-strong'
+  else
+    #Illumos will support this, but solaris will not due to library differences in the systems
+    if meson.version().version_compare('>=1.2.0')
+      if target_machine.kernel() == 'illumos'
+        warning_flags += '-fstack-protector-strong'
+      endif
+    else
+    # TODO: Backup method to detect illumos vs solaris
+    endif
+  endif
+
   if c.get_id().contains('gcc') and target_machine.system() == 'windows'
     #According to the link below, this is not needed in Windows...it also causes a bug in some versions of GCC for Windows.
     #https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90458

src/EULA.c

@@ -6761,7 +6761,7 @@ static eReturnValues scsi_Read_Check(tDevice*         device,
     else if (!zeroLengthTransfers)
     {
         set_Console_Colors(true, NOTE_COLOR);
-        printf("NOTE: Skipping testing for zero length transfers. This test should be done for highest compatibilty "
+        printf("NOTE: Skipping testing for zero length transfers. This test should be done for highest compatibility "
                "testing!\n");
         set_Console_Colors(true, CONSOLE_COLOR_DEFAULT);
     }