feat(tests): add test for JSON-download datafile action (#1868)

## Description
These two specs verify the “json-download” action type in the
`perform_action()`:
1. `0600` ensures that when a custom payload template is provided,
placeholders ({{ datasetPid }}, {{ sourceFolder }}, {{ filesPath }}, {{
jwt }}) are correctly replaced and sent in the request body.
2. `0610` ensures that if payload is missing (empty), the default object
(auth_token, jwt, dataset, directory, files) is still constructed and
sent.

## Motivation
To guarantee that both code paths for JSON‐based downloads produce a
valid POST body—whether using a user-supplied template or falling back
to the built-in default—so downstream services always receive the
expected parameters.


## Fixes:
Please provide a list of the fixes implemented in this PR

* Items added


## Changes:
Please provide a list of the changes implemented by this PR

* changes made


## Tests included
- [ ] Included for each change/fix?
- [ ] Passing? (Merge will not be approved unless this is checked) 

## Documentation
- [ ] swagger documentation updated \[required\]
- [ ] official documentation updated \[nice-to-have\]

### official documentation info
If you have updated the official documentation, please provide PR # and
URL of the pages where the updates are included

## Backend version
- [ ] Does it require a specific version of the backend
- which version of the backend is required:

## Summary by Sourcery

Add unit tests for the JSON-download branch of DatafilesActionComponent
to ensure both custom payload templates and fallback defaults produce
the correct POST body

Tests:
- Update test configuration by reordering action entries and adding two
JSON-download cases
- Verify that a provided payload template correctly replaces
placeholders and is sent in the request body
- Verify that an empty payload triggers construction and sending of the
default JSON payload

Author: Junjiequan

src/app/datasets/datafiles-actions/datafiles-action.component.spec.ts

@@ -29,7 +29,7 @@ describe("1000: DatafilesActionComponent", () => {
   const actionsConfig = [
     {
       id: "eed8efec-4354-11ef-a3b5-d75573a5d37f",
-      order: 4,
+      order: 0,
       label: "Download All",
       files: "all",
       mat_icon: "download",
@@ -40,7 +40,7 @@ describe("1000: DatafilesActionComponent", () => {
     },
     {
       id: "3072fafc-4363-11ef-b9f9-ebf568222d26",
-      order: 3,
+      order: 1,
       label: "Download Selected",
       files: "selected",
       mat_icon: "download",
@@ -61,14 +61,54 @@ describe("1000: DatafilesActionComponent", () => {
     },
     {
       id: "fa3ce6ee-482d-11ef-95e9-ff2c80dd50bd",
-      order: 1,
+      order: 3,
+      label: "Notebook Selected",
+      files: "selected",
+      icon: "/assets/icons/jupyter_logo.png",
+      url: "https://notebook.scicat.org",
+      target: "_blank",
+      enabled: "#Selected",
+      authorization: ["#datasetAccess", "#datasetPublic"],
+    },
+    {
+      id: "fa3ce6ee-482d-11ef-95e9-ff2c80ddnews",
+      order: 4,
+      label: "Notebook Selected",
+      files: "selected",
+      type: "json-download",
+      icon: "/assets/icons/jupyter_logo.png",
+      url: "https://notebook.scicat.org",
+      target: "_blank",
+      enabled: "#Selected",
+      authorization: ["#datasetAccess", "#datasetPublic"],
+      filename: "{{ uuid }}.ipynb",
+    },
+    {
+      id: "test-test-test-test-1",
+      order: 5,
+      label: "Notebook Selected",
+      files: "selected",
+      type: "json-download",
+      icon: "/assets/icons/jupyter_logo.png",
+      url: "https://notebook.scicat.org",
+      target: "_blank",
+      enabled: "#Selected",
+      authorization: ["#datasetAccess", "#datasetPublic"],
+      payload: "",
+      filename: "{{ uuid }}.ipynb",
+    },
+    {
+      id: "test-test-test-test-2",
+      order: 6,
       label: "Notebook Selected",
       files: "selected",
+      type: "json-download",
       icon: "/assets/icons/jupyter_logo.png",
       url: "https://notebook.scicat.org",
       target: "_blank",
       enabled: "#Selected",
       authorization: ["#datasetAccess", "#datasetPublic"],
+      filename: "{{ uuid }}.ipynb",
     },
   ];
 
@@ -121,6 +161,8 @@ describe("1000: DatafilesActionComponent", () => {
     download_selected = 1,
     notebook_all = 2,
     notebook_selected = 3,
+    json_download_with_payload = 4,
+    json_download_without_payload = 5,
   }
 
   const usersControllerGetUserJWTV3 = () => ({
@@ -732,4 +774,69 @@ describe("1000: DatafilesActionComponent", () => {
       actionsConfig[actionSelectorType.notebook_selected].label,
     );
   });
+
+  it("0600: JSON-download action should fetch with customized payload fields when provided", async () => {
+    selectTestCase(
+      actionSelectorType.json_download_with_payload,
+      maxSizeType.higher,
+      selectedFilesType.none,
+    );
+    actionsConfig[actionSelectorType.json_download_with_payload].payload =
+      '{"test_id":"test-id","parameters":{"testField1":"{{ datasetPid }}","testField2":"{{ sourceFolder }}","files": {{ filesPath }},"jwt":"{{ jwt }}","scicat_url":"https://staging.scicat.ess.url","file_server_url":"sftserver2.esss.dk","file_server_port":"22"}}';
+    component.jwt = "TEST_JWT";
+    spyOn(window, "fetch").and.returnValue(
+      Promise.resolve(
+        new Response(new Blob(), {
+          status: 200,
+          statusText: "OK",
+          headers: { "Content-Type": "application/json" },
+        }),
+      ),
+    );
+    component.perform_action();
+
+    const [url, opts] = (window.fetch as jasmine.Spy).calls.mostRecent().args;
+    expect(url).toBe(
+      actionsConfig[actionSelectorType.json_download_with_payload].url,
+    );
+    expect(opts.method).toBe("POST");
+    expect(opts.headers["Content-Type"]).toBe("application/json");
+
+    const body = JSON.parse(opts.body);
+    expect(body.test_id).toBe("test-id");
+    expect(body.parameters.jwt).toBe("TEST_JWT");
+    expect(body.parameters.testField1).toBe(actionDataset.pid);
+    expect(body.parameters.testField2).toBe(actionDataset.sourceFolder);
+  });
+
+  it("0610: JSON-download action should fetch with default fields if payload is not provided", async () => {
+    selectTestCase(
+      actionSelectorType.json_download_without_payload,
+      maxSizeType.higher,
+      selectedFilesType.none,
+    );
+    component.jwt = "TEST_JWT2";
+    spyOn(window, "fetch").and.returnValue(
+      Promise.resolve(
+        new Response(new Blob(), {
+          status: 200,
+          statusText: "OK",
+          headers: { "Content-Type": "application/json" },
+        }),
+      ),
+    );
+    component.perform_action();
+
+    const [url, opts] = (window.fetch as jasmine.Spy).calls.mostRecent().args;
+    expect(url).toBe(
+      actionsConfig[actionSelectorType.json_download_without_payload].url,
+    );
+    expect(opts.method).toBe("POST");
+    expect(opts.headers["Content-Type"]).toBe("application/json");
+
+    const body = JSON.parse(opts.body);
+    expect(body.jwt).toBe("TEST_JWT2");
+    expect(body.dataset).toBe(actionDataset.pid);
+    expect(body.directory).toBe(actionDataset.sourceFolder);
+  });
 });