Skip to content

Commit 9a70a85

Browse files
authored
Hotfix_ARXML_Ethernet_Decode_Transmitters_Receivers (ebroecker#828)
1 parent 44d3121 commit 9a70a85

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

src/canmatrix/formats/arxml.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1960,18 +1960,20 @@ def decode_ethernet_helper(ea, float_factory):
19601960
try:
19611961
target_frame.header_id = int(pdu_triggering_header_id_map[ipdu_triggering], 0)
19621962
except:
1963-
target_frame.header_id = 0
1964-
# continue
1965-
1963+
pass
1964+
1965+
# In Case Neither transmitter Nor receiver
19661966
if comm_direction.text == "OUT":
19671967
target_frame.add_transmitter(ecu.name)
1968-
else:
1968+
elif comm_direction.text == "IN":
19691969
target_frame.add_receiver(ecu.name)
1970+
else:
1971+
pass
19701972

19711973
pdu_sig_mapping = ea.findall("I-SIGNAL-TO-I-PDU-MAPPING", ipdu)
19721974

19731975
get_signals(pdu_sig_mapping, target_frame, ea, None, float_factory)
1974-
target_frame.update_receiver()
1976+
# target_frame.update_receiver() # It will make transmitter and receiver worse
19751977
db.add_frame(target_frame)
19761978

19771979
return found_matrixes
@@ -2089,10 +2091,14 @@ def decode_can_helper(ea, float_factory, ignore_cluster_info):
20892091
else:
20902092
ecu = process_ecu(ecu_elem, ea)
20912093
nodes[ecu_elem] = ecu
2094+
2095+
# In Case Neither transmitter Nor receiver
20922096
if comm_direction.text == "OUT":
20932097
frame.add_transmitter(ecu.name)
2094-
else:
2098+
elif comm_direction.text == "IN":
20952099
frame.add_receiver(ecu.name)
2100+
else:
2101+
pass
20962102
db.add_ecu(ecu)
20972103
db.add_frame(frame)
20982104
for frame in db.frames:

0 commit comments

Comments
 (0)