Skip to content

stts22h_auto_increment_get() returns incorrect value #1

@a-wilhelm

Description

@a-wilhelm

stts22h_auto_increment_set() specifically sets the if_add_inc bit in the control register:

stts22h-pid/stts22h_reg.c

Lines 483 to 497 in 77a48c0

int32_t stts22h_auto_increment_set(stmdev_ctx_t *ctx, uint8_t val)
{
stts22h_ctrl_t ctrl;
int32_t ret;
ret = stts22h_read_reg(ctx, STTS22H_CTRL, (uint8_t *)&ctrl, 1);
if (ret == 0)
{
ctrl.if_add_inc = (uint8_t)val;
ret = stts22h_write_reg(ctx, STTS22H_CTRL, (uint8_t *)&ctrl, 1);
}
return ret;
}

However the corresponding stts22h_auto_increment_get() is returning the entire control register contents rather than just if_add_inc:

stts22h-pid/stts22h_reg.c

Lines 508 to 515 in 77a48c0

int32_t stts22h_auto_increment_get(stmdev_ctx_t *ctx, uint8_t *val)
{
int32_t ret;
ret = stts22h_read_reg(ctx, STTS22H_CTRL, (uint8_t *)&val, 1);
return ret;
}

Suggested fix:

int32_t stts22h_auto_increment_get(stmdev_ctx_t *ctx, uint8_t *val)
{
  stts22h_ctrl_t ctrl;
  int32_t ret;

  ret = stts22h_read_reg(ctx, STTS22H_CTRL, (uint8_t *)&ctrl, 1);

  *val = ctrl.if_add_inc;

  return ret;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions