Skip to content

Commit 8a22c27

Browse files
committed
fix(cicd): preserve snapshot TTL after PR deploy
Signed-off-by: mday-io <mdaytn@gmail.com>
1 parent d490134 commit 8a22c27

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

sqlmesh/integrations/github/cicd/controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,7 @@ def try_invalidate_pr_environment(self) -> None:
807807
Marks the PR environment for garbage collection.
808808
"""
809809
if self.bot_config.invalidate_environment_after_deploy:
810-
self._context.invalidate_environment(self.pr_environment_name, cleanup_snapshots=True)
810+
self._context.invalidate_environment(self.pr_environment_name)
811811

812812
def _update_check(
813813
self,

tests/integrations/github/cicd/test_github_controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ def test_try_invalidate_pr_environment(github_client, make_controller, mocker: M
572572
invalidate_controller._context, "invalidate_environment"
573573
)
574574
invalidate_controller.try_invalidate_pr_environment()
575-
invalidate_environment.assert_called_once_with("hello_world_2", cleanup_snapshots=True)
575+
invalidate_environment.assert_called_once_with("hello_world_2")
576576

577577
no_invalidate_controller = make_controller(
578578
"tests/fixtures/github/pull_request_synchronized.json",

0 commit comments

Comments
 (0)