fix code quality

Author: NicoleMGomes

src/sap_cloud_sdk/core/odata/_async_transport.py

@@ -91,15 +91,21 @@ async def request(
         if method.upper() in MUTATING_METHODS and self._csrf_enabled:
             extra[CSRF_HEADER] = await self._get_csrf_token()
             try:
-                return await self._execute(method, path, params=params, json=json, extra_headers=extra)
+                return await self._execute(
+                    method, path, params=params, json=json, extra_headers=extra
+                )
             except ODataAuthError as exc:
                 if exc.status_code == 403:
                     await self._invalidate_csrf_token()
                     extra[CSRF_HEADER] = await self._get_csrf_token()
-                    return await self._execute(method, path, params=params, json=json, extra_headers=extra)
+                    return await self._execute(
+                        method, path, params=params, json=json, extra_headers=extra
+                    )
                 raise
 
-        return await self._execute(method, path, params=params, json=json, extra_headers=extra)
+        return await self._execute(
+            method, path, params=params, json=json, extra_headers=extra
+        )
 
     def absolute_url(self, path: str) -> str:
         return self._base_url + "/" + path.lstrip("/")

src/sap_cloud_sdk/core/odata/_csrf.py

@@ -7,7 +7,11 @@
 
 import requests as _requests
 
-from sap_cloud_sdk.core.odata._constants import CSRF_FETCH_TIMEOUT, CSRF_FETCH_VALUE, CSRF_HEADER
+from sap_cloud_sdk.core.odata._constants import (
+    CSRF_FETCH_TIMEOUT,
+    CSRF_FETCH_VALUE,
+    CSRF_HEADER,
+)
 from sap_cloud_sdk.core.odata.exceptions import ODataCsrfError
 
 if TYPE_CHECKING:

src/sap_cloud_sdk/core/odata/_models.py

@@ -2,7 +2,7 @@
 
 from __future__ import annotations
 
-from dataclasses import dataclass, field
+from dataclasses import dataclass
 from typing import Any, ClassVar
 
 

src/sap_cloud_sdk/core/odata/_query.py

@@ -133,9 +133,7 @@ def to_params(self) -> dict[str, str]:
         if self._filter is not None:
             params[QUERY_FILTER] = str(self._filter)
         if self._orderby:
-            params[QUERY_ORDERBY] = ",".join(
-                f"{f} {d.value}" for f, d in self._orderby
-            )
+            params[QUERY_ORDERBY] = ",".join(f"{f} {d.value}" for f, d in self._orderby)
         if self._top is not None:
             params[QUERY_TOP] = str(self._top)
         if self._skip is not None:

src/sap_cloud_sdk/core/odata/_request_builders.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 import dataclasses
-from typing import Any, Generic, Iterator, TypeVar, TYPE_CHECKING
+from typing import Any, Generic, Iterator, TypeVar, TYPE_CHECKING, cast
 
 from sap_cloud_sdk.core.odata._constants import (
     DELETE,
@@ -14,7 +14,10 @@
     PUT,
 )
 from sap_cloud_sdk.core.odata._query import OrderDirection, StructuredQuery
-from sap_cloud_sdk.core.odata._response import deserialize_collection, deserialize_single
+from sap_cloud_sdk.core.odata._response import (
+    deserialize_collection,
+    deserialize_single,
+)
 from sap_cloud_sdk.core.odata._pagination import ODataPageIterator
 
 if TYPE_CHECKING:
@@ -57,9 +60,7 @@ class GetAllRequestBuilder(Generic[T]):
         )
     """
 
-    def __init__(
-        self, transport: "ODataHttpTransport", entity_type: type[T]
-    ) -> None:
+    def __init__(self, transport: "ODataHttpTransport", entity_type: type[T]) -> None:
         self._transport = transport
         self._entity_type = entity_type
         self._query = StructuredQuery()
@@ -105,10 +106,13 @@ def iterate_pages(self) -> Iterator[list[T]]:
         params = self._query.to_params()
         if params:
             from urllib.parse import urlencode
+
             first_url += "?" + urlencode(params)
 
         iterator = ODataPageIterator(
-            fetch_page=lambda url: self._transport.request(GET, _strip_base(url, self._transport._base_url)),
+            fetch_page=lambda url: self._transport.request(
+                GET, _strip_base(url, self._transport._base_url)
+            ),
             entity_type=self._entity_type,
             first_url=first_url,
         )
@@ -124,7 +128,7 @@ def _strip_base(url: str, base_url: str) -> str:
     """Strip *base_url* prefix from *url* to get a relative path."""
     prefix = base_url + "/"
     if url.startswith(prefix):
-        return url[len(prefix):]
+        return url[len(prefix) :]
     return url
 
 
@@ -160,17 +164,16 @@ def execute(self) -> T:
 class CreateRequestBuilder(Generic[T]):
     """Builder for OData entity creation (POST)."""
 
-    def __init__(
-        self, transport: "ODataHttpTransport", entity: T
-    ) -> None:
+    def __init__(self, transport: "ODataHttpTransport", entity: T) -> None:
         self._transport = transport
         self._entity = entity
 
     def execute(self) -> T:
         """Create the entity and return the server response as the same type."""
         entity_type = type(self._entity)
         path = _entity_set_path(entity_type)
-        body = self._entity.to_dict() if hasattr(self._entity, "to_dict") else dataclasses.asdict(self._entity)  # type: ignore[arg-type]
+        e: Any = cast(Any, self._entity)
+        body = e.to_dict() if hasattr(e, "to_dict") else dataclasses.asdict(e)
         data = self._transport.request(POST, path, json=body)
         return deserialize_single(data, entity_type)
 
@@ -205,7 +208,8 @@ def execute(self) -> T:
             )
         key = {k: getattr(self._entity, k) for k in key_fields}
         path = _entity_set_path(entity_type) + _build_key_segment(key)
-        body = self._entity.to_dict() if hasattr(self._entity, "to_dict") else dataclasses.asdict(self._entity)  # type: ignore[arg-type]
+        e: Any = cast(Any, self._entity)
+        body = e.to_dict() if hasattr(e, "to_dict") else dataclasses.asdict(e)
         method = PUT if self._use_put else PATCH
         extra: dict[str, str] = {}
         if self._etag is not None:

src/sap_cloud_sdk/core/odata/_response.py

@@ -23,7 +23,11 @@ def deserialize_single(data: dict[str, Any], entity_type: type[T]) -> T:
             f"{entity_type!r} is not a dataclass — cannot deserialize"
         )
     try:
-        payload = data.get(RESPONSE_VALUE, data) if isinstance(data.get(RESPONSE_VALUE), dict) else data
+        payload = (
+            data.get(RESPONSE_VALUE, data)
+            if isinstance(data.get(RESPONSE_VALUE), dict)
+            else data
+        )
         known = {f.name for f in dataclasses.fields(entity_type)}  # type: ignore[arg-type]
         kwargs = {k: v for k, v in payload.items() if k in known}
         return entity_type(**kwargs)  # type: ignore[call-arg]

src/sap_cloud_sdk/core/odata/_transport.py

@@ -92,15 +92,21 @@ def request(
         if method.upper() in MUTATING_METHODS and self._csrf is not None:
             extra[CSRF_HEADER] = self._csrf.get()
             try:
-                return self._execute(method, path, params=params, json=json, extra_headers=extra)
+                return self._execute(
+                    method, path, params=params, json=json, extra_headers=extra
+                )
             except ODataAuthError as exc:
                 if exc.status_code == 403:
                     self._csrf.invalidate()
                     extra[CSRF_HEADER] = self._csrf.get()
-                    return self._execute(method, path, params=params, json=json, extra_headers=extra)
+                    return self._execute(
+                        method, path, params=params, json=json, extra_headers=extra
+                    )
                 raise
 
-        return self._execute(method, path, params=params, json=json, extra_headers=extra)
+        return self._execute(
+            method, path, params=params, json=json, extra_headers=extra
+        )
 
     def absolute_url(self, path: str) -> str:
         """Return the full URL for *path* relative to the service base."""

src/sap_cloud_sdk/core/odata/exceptions.py

@@ -2,10 +2,7 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING
-
-if TYPE_CHECKING:
-    import requests
+from typing import Any
 
 
 class ODataError(Exception):
@@ -15,8 +12,8 @@ class ODataError(Exception):
 class ODataRequestError(ODataError):
     """HTTP-level error from an OData service (non-2xx response)."""
 
-    def __init__(self, response: "requests.Response") -> None:
-        self.status_code = response.status_code
+    def __init__(self, response: Any) -> None:
+        self.status_code: int = response.status_code
         self.response = response
         try:
             body = response.json()