feat(adms): add get-by-id and update (PATCH) to all config entities

adwitiyasushant · adwitiyasushant · commit a790fb5a2e8d · 2026-06-10T17:50:49.000+05:30
AllowedDomain, DocumentType, BusinessObjectNodeType, and
DocumentTypeBusinessObjectTypeMap were each missing two operations
visible in the live API (GET by key, PATCH):

  config.get_allowed_domain(id)           → GET AllowedDomain(id)
  config.update_allowed_domain(id, input) → PATCH AllowedDomain(id)
  config.get_document_type(id)
  config.update_document_type(id, input)
  config.get_business_object_type(id)
  config.update_business_object_type(id, input)
  config.get_type_mapping(id)             → GET TypeMap(id)

All 8 methods have sync + async variants. Three new Update*Input
dataclasses model the PATCH payload (only non-None fields sent).
Eight new Operation enum entries; total adms operations 33 → 40 → 131.
diff --git a/src/sap_cloud_sdk/adms/__init__.py b/src/sap_cloud_sdk/adms/__init__.py
@@ -79,7 +79,10 @@
     JobStatus,
     JobType,
     ScanStatus,
+    UpdateAllowedDomainInput,
+    UpdateBusinessObjectNodeTypeInput,
     UpdateDocumentInput,
+    UpdateDocumentTypeInput,
     ZipDownloadJobParameters,
 )
 from sap_cloud_sdk.adms._query_options import (
@@ -131,6 +134,9 @@
     "BusinessObjectNodeType",
     "CreateAllowedDomainInput",
     "CreateBusinessObjectNodeTypeInput",
+    "UpdateAllowedDomainInput",
+    "UpdateBusinessObjectNodeTypeInput",
+    "UpdateDocumentTypeInput",
     "CreateDocumentTypeBoTypeMapInput",
     "CreateDocumentTypeInput",
     "DocumentType",
diff --git a/src/sap_cloud_sdk/adms/_configuration_api.py b/src/sap_cloud_sdk/adms/_configuration_api.py
@@ -20,6 +20,9 @@
     CreateDocumentTypeInput,
     DocumentType,
     DocumentTypeBusinessObjectTypeMap,
+    UpdateAllowedDomainInput,
+    UpdateBusinessObjectNodeTypeInput,
+    UpdateDocumentTypeInput,
 )
 from sap_cloud_sdk.adms._query_options import ConfigQueryOptions
 from sap_cloud_sdk.adms.config import _CONFIG_SERVICE_PATH
@@ -57,6 +60,27 @@ def create_allowed_domain(self, payload: CreateAllowedDomainInput) -> AllowedDom
         )
         return AllowedDomain.from_dict(resp.json())
 
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_GET_ALLOWED_DOMAIN)
+    def get_allowed_domain(self, allowed_domain_id: str) -> AllowedDomain:
+        """Fetch a single AllowedDomain by its UUID."""
+        resp = self._http.get(
+            build_allowed_domain_key_path(allowed_domain_id),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return AllowedDomain.from_dict(resp.json())
+
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_UPDATE_ALLOWED_DOMAIN)
+    def update_allowed_domain(
+        self, allowed_domain_id: str, payload: UpdateAllowedDomainInput
+    ) -> AllowedDomain:
+        """Update an existing AllowedDomain entry (PATCH — only sent fields change)."""
+        resp = self._http.patch(
+            build_allowed_domain_key_path(allowed_domain_id),
+            json=payload.to_odata_dict(),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return AllowedDomain.from_dict(resp.json())
+
     @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_DELETE_ALLOWED_DOMAIN)
     def delete_allowed_domain(self, allowed_domain_id: str) -> None:
         """Remove an entry from the domain allow-list."""
@@ -87,6 +111,27 @@ def create_document_type(self, payload: CreateDocumentTypeInput) -> DocumentType
         )
         return DocumentType.from_dict(resp.json())
 
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_GET_DOCUMENT_TYPE)
+    def get_document_type(self, document_type_id: str) -> DocumentType:
+        """Fetch a single DocumentType by its ID."""
+        resp = self._http.get(
+            build_document_type_key_path(document_type_id),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return DocumentType.from_dict(resp.json())
+
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_UPDATE_DOCUMENT_TYPE)
+    def update_document_type(
+        self, document_type_id: str, payload: UpdateDocumentTypeInput
+    ) -> DocumentType:
+        """Update an existing DocumentType (PATCH — only sent fields change)."""
+        resp = self._http.patch(
+            build_document_type_key_path(document_type_id),
+            json=payload.to_odata_dict(),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return DocumentType.from_dict(resp.json())
+
     @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_DELETE_DOCUMENT_TYPE)
     def delete_document_type(self, document_type_id: str) -> None:
         """Delete a document type classification."""
@@ -122,6 +167,35 @@ def create_business_object_type(
         )
         return BusinessObjectNodeType.from_dict(resp.json())
 
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_GET_BUSINESS_OBJECT_TYPE)
+    def get_business_object_type(
+        self, business_object_node_type_unique_id: str
+    ) -> BusinessObjectNodeType:
+        """Fetch a single BusinessObjectNodeType by its unique ID."""
+        resp = self._http.get(
+            build_business_object_node_type_key_path(
+                business_object_node_type_unique_id
+            ),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return BusinessObjectNodeType.from_dict(resp.json())
+
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_UPDATE_BUSINESS_OBJECT_TYPE)
+    def update_business_object_type(
+        self,
+        business_object_node_type_unique_id: str,
+        payload: UpdateBusinessObjectNodeTypeInput,
+    ) -> BusinessObjectNodeType:
+        """Update an existing BusinessObjectNodeType (PATCH)."""
+        resp = self._http.patch(
+            build_business_object_node_type_key_path(
+                business_object_node_type_unique_id
+            ),
+            json=payload.to_odata_dict(),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return BusinessObjectNodeType.from_dict(resp.json())
+
     @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_DELETE_BUSINESS_OBJECT_TYPE)
     def delete_business_object_type(
         self, business_object_node_type_unique_id: str
@@ -163,6 +237,17 @@ def create_type_mapping(
         )
         return DocumentTypeBusinessObjectTypeMap.from_dict(resp.json())
 
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_GET_DOCTYPE_BOTYPE_MAP)
+    def get_type_mapping(
+        self, document_type_bo_type_map_id: str
+    ) -> DocumentTypeBusinessObjectTypeMap:
+        """Fetch a single DocumentType ↔ BusinessObjectNodeType mapping by its UUID."""
+        resp = self._http.get(
+            build_doctype_botype_map_key_path(document_type_bo_type_map_id),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return DocumentTypeBusinessObjectTypeMap.from_dict(resp.json())
+
     @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_DELETE_DOCTYPE_BOTYPE_MAP)
     def delete_type_mapping(self, document_type_bo_type_map_id: str) -> None:
         """Delete a DocumentType ↔ BusinessObjectNodeType mapping."""
@@ -205,6 +290,27 @@ async def create_allowed_domain(
         )
         return AllowedDomain.from_dict(resp.json())
 
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_GET_ALLOWED_DOMAIN)
+    async def get_allowed_domain(self, allowed_domain_id: str) -> AllowedDomain:
+        """Async variant of :meth:`_ConfigurationApi.get_allowed_domain` — same semantics."""
+        resp = await self._http.get(
+            build_allowed_domain_key_path(allowed_domain_id),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return AllowedDomain.from_dict(resp.json())
+
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_UPDATE_ALLOWED_DOMAIN)
+    async def update_allowed_domain(
+        self, allowed_domain_id: str, payload: UpdateAllowedDomainInput
+    ) -> AllowedDomain:
+        """Async variant of :meth:`_ConfigurationApi.update_allowed_domain` — same semantics."""
+        resp = await self._http.patch(
+            build_allowed_domain_key_path(allowed_domain_id),
+            json=payload.to_odata_dict(),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return AllowedDomain.from_dict(resp.json())
+
     @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_DELETE_ALLOWED_DOMAIN)
     async def delete_allowed_domain(self, allowed_domain_id: str) -> None:
         """Async variant of :meth:`_ConfigurationApi.delete_allowed_domain` — same semantics."""
@@ -237,6 +343,27 @@ async def create_document_type(
         )
         return DocumentType.from_dict(resp.json())
 
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_GET_DOCUMENT_TYPE)
+    async def get_document_type(self, document_type_id: str) -> DocumentType:
+        """Async variant of :meth:`_ConfigurationApi.get_document_type` — same semantics."""
+        resp = await self._http.get(
+            build_document_type_key_path(document_type_id),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return DocumentType.from_dict(resp.json())
+
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_UPDATE_DOCUMENT_TYPE)
+    async def update_document_type(
+        self, document_type_id: str, payload: UpdateDocumentTypeInput
+    ) -> DocumentType:
+        """Async variant of :meth:`_ConfigurationApi.update_document_type` — same semantics."""
+        resp = await self._http.patch(
+            build_document_type_key_path(document_type_id),
+            json=payload.to_odata_dict(),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return DocumentType.from_dict(resp.json())
+
     @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_DELETE_DOCUMENT_TYPE)
     async def delete_document_type(self, document_type_id: str) -> None:
         """Async variant of :meth:`_ConfigurationApi.delete_document_type` — same semantics."""
@@ -272,6 +399,35 @@ async def create_business_object_type(
         )
         return BusinessObjectNodeType.from_dict(resp.json())
 
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_GET_BUSINESS_OBJECT_TYPE)
+    async def get_business_object_type(
+        self, business_object_node_type_unique_id: str
+    ) -> BusinessObjectNodeType:
+        """Async variant of :meth:`_ConfigurationApi.get_business_object_type` — same semantics."""
+        resp = await self._http.get(
+            build_business_object_node_type_key_path(
+                business_object_node_type_unique_id
+            ),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return BusinessObjectNodeType.from_dict(resp.json())
+
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_UPDATE_BUSINESS_OBJECT_TYPE)
+    async def update_business_object_type(
+        self,
+        business_object_node_type_unique_id: str,
+        payload: UpdateBusinessObjectNodeTypeInput,
+    ) -> BusinessObjectNodeType:
+        """Async variant of :meth:`_ConfigurationApi.update_business_object_type` — same semantics."""
+        resp = await self._http.patch(
+            build_business_object_node_type_key_path(
+                business_object_node_type_unique_id
+            ),
+            json=payload.to_odata_dict(),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return BusinessObjectNodeType.from_dict(resp.json())
+
     @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_DELETE_BUSINESS_OBJECT_TYPE)
     async def delete_business_object_type(
         self, business_object_node_type_unique_id: str
@@ -313,6 +469,17 @@ async def create_type_mapping(
         )
         return DocumentTypeBusinessObjectTypeMap.from_dict(resp.json())
 
+    @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_GET_DOCTYPE_BOTYPE_MAP)
+    async def get_type_mapping(
+        self, document_type_bo_type_map_id: str
+    ) -> DocumentTypeBusinessObjectTypeMap:
+        """Async variant of :meth:`_ConfigurationApi.get_type_mapping` — same semantics."""
+        resp = await self._http.get(
+            build_doctype_botype_map_key_path(document_type_bo_type_map_id),
+            service_base=_CONFIG_SERVICE_PATH,
+        )
+        return DocumentTypeBusinessObjectTypeMap.from_dict(resp.json())
+
     @record_metrics(Module.ADMS, Operation.ADMS_CONFIG_DELETE_DOCTYPE_BOTYPE_MAP)
     async def delete_type_mapping(self, document_type_bo_type_map_id: str) -> None:
         """Async variant of :meth:`_ConfigurationApi.delete_type_mapping` — same semantics."""
diff --git a/src/sap_cloud_sdk/adms/_models.py b/src/sap_cloud_sdk/adms/_models.py
@@ -631,6 +631,34 @@ def to_odata_dict(self) -> dict:
         return d
 
 
+@dataclass
+class UpdateAllowedDomainInput:
+    """Input for updating an existing :class:`AllowedDomain` entry (PATCH).
+
+    Only non-``None`` fields are included in the PATCH payload.
+
+    Attributes:
+        host_name: New hostname.
+        protocol: New protocol (``"https"`` or ``"http"``).
+        port: New port.  Pass ``0`` to explicitly clear an existing port.
+    """
+
+    host_name: str | None = None
+    protocol: str | None = None
+    port: int | None = None
+
+    def to_odata_dict(self) -> dict:
+        """Serialise only non-None fields to the OData PATCH payload."""
+        d: dict = {}
+        if self.host_name is not None:
+            d["AllowedDomainHostName"] = self.host_name
+        if self.protocol is not None:
+            d["AllowedDomainProtocol"] = self.protocol
+        if self.port is not None:
+            d["AllowedDomainPort"] = self.port
+        return d
+
+
 @dataclass
 class DocumentTypeText:
     """Localization entry for a :class:`DocumentType` (CAP ``texts`` deep-insert).
@@ -753,6 +781,29 @@ def to_odata_dict(self) -> dict:
         return d
 
 
+@dataclass
+class UpdateDocumentTypeInput:
+    """Input for updating an existing :class:`DocumentType` (PATCH).
+
+    Only non-``None`` fields are included in the PATCH payload.
+
+    Attributes:
+        document_type_name: New human-readable label.
+        document_type_description: New description.
+    """
+
+    document_type_name: str | None = None
+    document_type_description: str | None = None
+
+    def to_odata_dict(self) -> dict:
+        d: dict = {}
+        if self.document_type_name is not None:
+            d["DocumentTypeName"] = self.document_type_name
+        if self.document_type_description is not None:
+            d["DocumentTypeDescription"] = self.document_type_description
+        return d
+
+
 @dataclass
 class BusinessObjectNodeType:
     """Tenant-configured business object node type.
@@ -832,6 +883,25 @@ def to_odata_dict(self) -> dict:
         return d
 
 
+@dataclass
+class UpdateBusinessObjectNodeTypeInput:
+    """Input for updating an existing :class:`BusinessObjectNodeType` (PATCH).
+
+    Only non-``None`` fields are included in the PATCH payload.
+
+    Attributes:
+        business_object_node_type_name: New human-readable label.
+    """
+
+    business_object_node_type_name: str | None = None
+
+    def to_odata_dict(self) -> dict:
+        d: dict = {}
+        if self.business_object_node_type_name is not None:
+            d["BusinessObjectNodeTypeName"] = self.business_object_node_type_name
+        return d
+
+
 @dataclass
 class DocumentTypeBusinessObjectTypeMap:
     """Mapping that controls which document types are allowed for a business object node type.
diff --git a/src/sap_cloud_sdk/core/telemetry/operation.py b/src/sap_cloud_sdk/core/telemetry/operation.py
@@ -115,7 +115,14 @@ class Operation(str, Enum):
     ADMS_CONFIG_DELETE_BUSINESS_OBJECT_TYPE = "config_delete_business_object_type"
     ADMS_CONFIG_GET_ALL_DOCTYPE_BOTYPE_MAPS = "config_get_all_doctype_botype_maps"
     ADMS_CONFIG_CREATE_DOCTYPE_BOTYPE_MAP = "config_create_doctype_botype_map"
+    ADMS_CONFIG_GET_DOCTYPE_BOTYPE_MAP = "config_get_doctype_botype_map"
     ADMS_CONFIG_DELETE_DOCTYPE_BOTYPE_MAP = "config_delete_doctype_botype_map"
+    ADMS_CONFIG_GET_ALLOWED_DOMAIN = "config_get_allowed_domain"
+    ADMS_CONFIG_UPDATE_ALLOWED_DOMAIN = "config_update_allowed_domain"
+    ADMS_CONFIG_GET_DOCUMENT_TYPE = "config_get_document_type"
+    ADMS_CONFIG_UPDATE_DOCUMENT_TYPE = "config_update_document_type"
+    ADMS_CONFIG_GET_BUSINESS_OBJECT_TYPE = "config_get_business_object_type"
+    ADMS_CONFIG_UPDATE_BUSINESS_OBJECT_TYPE = "config_update_business_object_type"
 
     # AI Core Operations
     AICORE_SET_CONFIG = "set_aicore_config"
diff --git a/tests/core/unit/telemetry/test_operation.py b/tests/core/unit/telemetry/test_operation.py
@@ -202,5 +202,5 @@ def test_operation_count(self):
         all_operations = list(Operation)
         # 3 auditlog + 11 destination + 10 certificate + 10 fragment + 8 objectstore
         # + 2 extensibility + 2 aicore + 23 dms + 4 agentgateway + 13 agent_memory
-        # + 5 data_anonymization + 33 adms = 124
-        assert len(all_operations) == 124
+        # + 5 data_anonymization + 40 adms = 131
+        assert len(all_operations) == 131
