Skip to content

Commit 5b55049

Browse files
fix(adms): change size_in_byte fields from float to int
DocumentSizeInByte and DocContentVersionSizeInByte are Decimal(12) in the CDS — whole-number byte counts. float allows fractional values that can never occur and loses precision for files > 2^53 bytes. Affected fields: Document.document_size_in_byte: float | None → int | None DocumentContentVersion.doc_content_version_size_in_byte: float | None → int | None Test fixture updated: DocumentSizeInByte: 1024.0 → 1024.
1 parent 144e727 commit 5b55049

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/sap_cloud_sdk/adms/_models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class DocumentContentVersion:
126126
doc_content_version_comment: str | None = None
127127
doc_content_version_is_latest: bool | None = None
128128
doc_content_version_mime_type: str | None = None
129-
doc_content_version_size_in_byte: float | None = None
129+
doc_content_version_size_in_byte: int | None = None
130130
# Internal object-store URI — do not expose to end users.
131131
doc_content_version_stream_uri: str | None = None
132132
doc_content_version_content_hash: str | None = None
@@ -194,7 +194,7 @@ class Document:
194194

195195
document_mime_type: str | None = None
196196
document_description: str | None = None
197-
document_size_in_byte: float | None = None
197+
document_size_in_byte: int | None = None
198198
# Internal object store URI — do NOT expose directly to end users.
199199
document_content_stream_uri: str | None = None
200200
# Only populated for BaseType.URL documents.

tests/adms/unit/test_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def test_from_dict_full(self):
7878
"DocumentTypeID": "INVOICE",
7979
"DocumentState": "CLEAN",
8080
"DocumentMimeType": "application/pdf",
81-
"DocumentSizeInByte": 1024.0,
81+
"DocumentSizeInByte": 1024,
8282
"DocumentIsLocked": False,
8383
}
8484
doc = Document.from_dict(data)

0 commit comments

Comments
 (0)