-
Notifications
You must be signed in to change notification settings - Fork 82
Closed
Labels
Description
Seems like we just need to change here:
TinCanPHP/tests/VersionTest.php
Lines 23 to 33 in 522afdb
public function testStaticFactoryReturnsInstance() { | |
$this->assertInstanceOf("TinCan\Version", Version::v101(), "factory returns instance"); | |
} | |
public function testToString() { | |
$this->assertInternalType("string", (string) Version::v101(), "object converts to string"); | |
} | |
public function testHasValueReturnsBool() { | |
$this->assertTrue(Version::v101()->hasValue(Version::V101), "object has correct value"); | |
} |
and:
Lines 35 to 45 in 522afdb
const V101 = "1.0.1"; | |
const V100 = "1.0.0"; | |
const V095 = "0.95"; | |
/**#@- */ | |
/** @var array string => bool */ | |
private static $supported = [ | |
self::V101 => true, | |
self::V100 => true, | |
self::V095 => false | |
]; |
Should we modify this so that any 1.0.x version is supported?