fix: fix clippy pipeline

Author: matteobeltrami

src/routing_handler.rs

@@ -480,7 +480,7 @@ mod routing_handler_tests {
     }
 
     #[test]
-    /// Tests handling a FloodResponse
+    /// Tests handling a `FloodResponse`
     fn test_handle_flood_response() {
         let (sender, _receiver) = unbounded();
         let mut handler = RoutingHandler::new(1, NodeType::Client, HashMap::new(), sender);
@@ -513,7 +513,7 @@ mod routing_handler_tests {
     }
 
     #[test]
-    /// Tests handling an Ack
+    /// Tests handling an `Ack`
     fn test_handle_ack() {
         let (sender, _receiver) = unbounded();
         let mut handler = RoutingHandler::new(1, NodeType::Client, HashMap::new(), sender);
@@ -541,7 +541,7 @@ mod routing_handler_tests {
     }
 
     #[test]
-    /// Tests the network_view update functionality after receiving a FloodResponse
+    /// Tests the `network_view` update functionality after receiving a `FloodResponse`
     fn test_flood_response_network_update() {
         let (mut handler, _) = create_test_routing_handler();
         handler.flood_counter = 5;
@@ -562,7 +562,7 @@ mod routing_handler_tests {
     }
 
     #[test]
-    /// Tests ErrorInRouting Nack handling
+    /// Tests `ErrorInRouting` Nack handling
     fn test_nack_handling_error_recovery() {
         let (mut handler, _) = create_test_routing_handler();
 
@@ -592,7 +592,7 @@ mod routing_handler_tests {
     }
 
     #[test]
-    /// Tests retry_send
+    /// Tests `retry_send`
     fn test_retry_send_mechanism() {
         let (mut handler, _) = create_test_routing_handler();
 

src/types.rs

@@ -90,6 +90,7 @@ pub struct MediaFile {
 }
 
 impl MediaFile {
+    #[must_use]
     pub fn new(title: String, content: Vec<Bytes>) -> Self {
         Self {
             id: Uuid::new_v4(),
@@ -98,26 +99,30 @@ impl MediaFile {
         }
     }
 
-    pub fn from_u8(filename: String, data: Vec<u8>) -> Self {
+    #[must_use]
+    pub fn from_u8(filename: String, data: &[u8]) -> Self {
         let chunk_size = 1024;
         let content: Vec<Bytes> = data
             .chunks(chunk_size)
-            .map(|chunk| chunk.to_vec())
+            .map(<[u8]>::to_vec)
             .collect();
 
         Self::new(filename, content)
     }
 
+    #[must_use]
     pub fn get_title(&self) -> &str {
         &self.title
     }
 
+    #[must_use]
     pub fn get_content(&self) -> &Vec<Bytes> {
         &self.content
     }
 
+    #[must_use]
     pub fn get_size(&self) -> usize {
-        self.content.iter().map(|chunk| chunk.len()).sum()
+        self.content.iter().map(Vec::len).sum()
     }
 }
 
@@ -317,29 +322,41 @@ pub enum ServerType {
 }
 
 pub mod file_conversion {
-    use super::*;
+    use super::{MediaFile, TextFile};
     use std::fs;
     use std::path::Path;
 
+    /// Converts a file path into a `MediaFile`.
+    ///
+    /// # Errors
+    ///
+    /// Returns an error if the file cannot be read, parsed, or converted
+    /// into a `MediaFile`.
     pub fn file_to_media_file(file_path: &str) -> Result<MediaFile, Box<dyn std::error::Error>> {
         let filename = Path::new(file_path)
             .file_name()
             .and_then(|name| name.to_str())
             .unwrap_or("unknown")
             .to_string();
 
-        let data = fs::read(file_path.to_string())?;
-        Ok(MediaFile::from_u8(filename, data))
+        let data = fs::read(file_path)?;
+        Ok(MediaFile::from_u8(filename, &data))
     }
 
+    /// Converts a file path into a `TextFile`.
+    ///
+    /// # Errors
+    ///
+    /// Returns an error if the file cannot be read, parsed, or converted
+    /// into a `TextFile`.
     pub fn file_to_text_file(file_path: &str) -> Result<TextFile, Box<dyn std::error::Error>> {
         let filename = Path::new(file_path)
             .file_stem()
             .and_then(|name| name.to_str())
             .unwrap_or("unknown")
             .to_string();
 
-        let content = fs::read_to_string(file_path.to_string())?;
+        let content = fs::read_to_string(file_path)?;
 
         Ok(TextFile::new(filename, content, vec![]))
     }