Migrate Core Prompts from Compiled Bundle to Disk-Based Loading

[pedramamini]

Summary

Migrate all 19 core system prompts from compile-time bundling to runtime disk-based loading, with a Maestro Prompts UI tab for viewing/editing/resetting prompts.

Key Features

• Prompts loaded once at startup from Resources/prompts/core/
• User customizations stored in userData/core-prompts-customizations.json
• New "Maestro Prompts" tab in Right Bar for editing
• Changes take effect immediately (no restart required)
• Customizations persist across app updates

Phase Documents

Phase	Description
00	Overview & Architecture
01	Core Infrastructure - prompt-manager.ts
02	Preload Bridge - IPC handlers
03	Initialize at Startup
04	Migrate Main Process Imports
05	Migrate Renderer Imports (Part 1)
06	Migrate Renderer Imports (Part 2)
07	Centralized Renderer Init
08	Remove Legacy Build System
09	Maestro Prompts UI Tab
10	Update Tests
11	Update Documentation
12	Final Validation

Attachments

DISK-PROMPTS-00.md
DISK-PROMPTS-01.md
DISK-PROMPTS-02.md
DISK-PROMPTS-03.md
DISK-PROMPTS-04.md
DISK-PROMPTS-05.md
DISK-PROMPTS-06.md
DISK-PROMPTS-07.md
DISK-PROMPTS-08.md
DISK-PROMPTS-09.md
DISK-PROMPTS-10.md
DISK-PROMPTS-11.md
DISK-PROMPTS-12.md

[andrew-t-james-wc]

I will pick this up after next release.

[jeffscottward]

@andrew-t-james-wc we are now at [v0.15.0-RC]. Do you want to tackle? Check with Pedram maybe?

[scriptease]

I'll start working on it :)

[scriptease]

Gist

Starting from the initial 13-file playbook (commit 4 baseline), the changes across the 3 commits were:

1. Phase 00 + 09 revised — UI moved from Right Bar tab to Settings modal tab. Phase 09 rewritten with theme prop pattern matching existing Settings tabs.
2. Phase 01 + 04 + 08 revised — Shared src/shared/promptDefinitions.ts extracted so CLI and main process use the same constants. CLI loader uses getPromptFilename() instead of hardcoded map.
3. Critical review + fixes — Prompt count corrected 19→23 (added tab-naming, director-notes, feedback, feedback-conversation). 12 missing import sites added across Phases 04-06. Wrong file reference fixed (useSettings.ts → settingsStore.ts). Build script list corrected.
4. Phase 13 added — Group Chat settings tab removal with standing instructions migration.
5. Two review rounds fixed — Renderer cache invalidation (refreshRendererPrompts()), rendering gate, fail-loud loaders, safe reset ordering, CLI path fix, unsaved edit confirmation, reset confirmation, double-append guard, error handling specificity.

---

Detail Summary by Phase

Phase	State	Key Changes from Baseline
00	Heavily revised	Count 19→23, 12 missing files added to modify list, Right Bar→Settings, Phase 13 row added, dual-system coexistence principle, dead code note for wizardInlineSystemPrompt
01	Revised	4 prompts added to CORE_PROMPTS + PROMPT_IDS, extracted to src/shared/promptDefinitions.ts, loadUserCustomizations() now distinguishes ENOENT from real errors, resetPrompt() reads bundled file before deleting customization, unused type PromptDefinition import removed
02	Unchanged	—
03	Minor	"19 prompts" → "23 prompts" in validation
04	Heavily revised	Added 4 missing main-process files (moderator, director-notes, tabNaming, feedback dynamic import), CLI loader uses shared getPromptFilename(), dev path fixed to src/prompts/
05	Full rewrite	Was 3 files (wrong ones), now 7 files (stores + hooks). force param on all loaders. Fail-loud pattern: throw on !result.success
06	Full rewrite	Added inlineWizardConversation.ts + inlineWizardDocumentGeneration.ts. Same force + fail-loud pattern
07	Full rewrite	Added refreshRendererPrompts(), expanded from 5→13 loaders, loadAll(force) helper, App.tsx gates rendering on promptsReady
08	Revised	Build script list corrected (dev:main, dev:main:prod-data, build, validate:push), added dynamic import grep, src/prompts/index.ts re-exports from shared
09	Full rewrite	Right Bar→Settings modal, theme prop pattern, refreshRendererPrompts() called after save/reset, success message auto-dismiss, unsaved edit confirmation, reset confirmation, prerequisites updated to 01-03+07, searchable settings integration
10	Unchanged	—
11	Minor	"Add new prompt" docs point to shared/promptDefinitions.ts
12	Minor	All "19" → "23"
13	New	Group Chat tab removal, standing instructions migration (with double-append guard)

---

Assumptions & Confidence

#	Assumption	Confidence	Risk if Wrong
1	The 23 .md files in src/prompts/ are the complete set — no others were added since the codebase scan	High	Missing prompts will fail to load at startup (hard fail, caught immediately)
2	feedbackConversationPrompt dynamic import in feedback.ts is the only import that bypasses src/prompts/index.ts	Medium	Other dynamic imports from generated/prompts.ts would break silently after Phase 08
3	getBundledPromptsPath() dev path (__dirname/../../src/prompts) resolves correctly for both main process and test environments	Medium	Prompts fail to load in dev; testable immediately
4	Standing instructions baked into prompt content (Phase 13) is the right migration strategy	Low	Users get frozen prompts, miss future bundled improvements. Template variable approach ({{STANDING_INSTRUCTIONS}}) is likely better — see discussion above
5	conductorProfile stays independent, no migration needed	High	Already uses template variable pattern, proven working
6	Settings search (searchableSettings.ts) requires explicit registration for new tabs	High	Tab just won't appear in search results — minor UX gap, not a crash
7	window.confirm() is acceptable UX for unsaved edit / reset confirmation in an Electron app	Medium	May look jarring; could be replaced with in-app modal later
8	Rendering gate (return null until prompts load) won't cause visible flicker	Medium	IPC calls should complete in <50ms since they read from in-memory cache, but if slow, users see a blank frame
9	All 13 renderer loaders can safely re-fetch via force=true without side effects	High	They only overwrite module-level string variables
10	The prompts:getAllIds IPC handler (Phase 02) is never called by any planned code	High	Dead API surface — harmless, but could be removed to reduce surface area
11	wizardInlineSystemPrompt is genuinely unused (exported but never imported)	High	If used in code we didn't find, it already works via the migration — just flagged for potential cleanup
12	Group Chat tab has no searchable settings registered (so removal is clean)	High	Verified — group chat is absent from searchableSettings.ts

Assumption #4 is the one that needs a decision before implementation. The rest are verifiable during implementation.

[scriptease]

DISKPROMPTS-revised00.md
DISKPROMPTS-revised01.md
DISKPROMPTS-revised02.md
DISKPROMPTS-revised03.md
DISKPROMPTS-revised04.md
DISKPROMPTS-revised05.md
DISKPROMPTS-revised06.md
DISKPROMPTS-revised07.md
DISKPROMPTS-revised08.md
DISKPROMPTS-revised09.md
DISKPROMPTS-revised10.md
DISKPROMPTS-revised11.md
DISKPROMPTS-revised12.md
DISKPROMPTS-revised13.md

[pedramamini]

Going with PR #798 + some cherry picking. Going into RC now. Then I'm going to leverage this capability to see if I can improve the system prompt issue where our agents are seemingly forgetting about auto-run docs and other capabilities.