Various improvements to muttdown #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'remove_sigil' option to also remove sigil from text/plain copy.
instead of processing it as markdown.
on some browswers.
Roguelazer
reviewed
May 22, 2018
|
|
||
| proc = subprocess.Popen(cmd, stdin=subprocess.PIPE, shell=False) | ||
| proc.communicate(rebuilt.as_string()) | ||
| proc.wait() |
Owner
There was a problem hiding this comment.
communicate waits for the process to end implicitly
Roguelazer
reviewed
May 22, 2018
| return message | ||
| except Exception: | ||
| except Exception as e: | ||
| sys.stderr.write('muttdown: '+str(e)) |
Roguelazer
reviewed
May 22, 2018
Owner
Roguelazer
left a comment
Roguelazer
left a comment
There was a problem hiding this comment.
sorry for the mega slow review; this looks like a great set of changes
can you run through flake8 and clean up style to match PEP8 (you can ignore line length warnings)
Author
|
Thanks, I'll make the suggested changes, run it through flake8, and submit another pull request. |
Owner
|
I also have another branch that adds working unit tests (well sort of) so you might want to wait until I land #6 and then rebase on master.
…--
James Brown,
currently mobile
On May 22, 2018, at 14:13, Grant Edwards ***@***.***> wrote:
Thanks,
I'll make the suggested changes, run it through flake8, and submit another pull request.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only remove the first occurance of the sigil, and add option to also remove it from plaintext version.
Allow main.py to run without installing (useful during development).
Add '!p' sigil that just encloses everything in pre /pre tags. Useful when you want to send ascii diagrams to HTML users.
Allow user to specify markdown extensions.
Return failure if sendmail subprocess fails.
Add 'utf8' option to tell muttdown to treat text/plain message as UTF8 when converting.