read-me: added version support table #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhbritton-RSK
force-pushed
the
read-me/version-support-table
branch
from
9318df9 to
13b20a2
Compare
nachoRSK
reviewed
May 16, 2025
README.md
Outdated
|
|
||
| | Utils Package Version | AdminUI Version | Notes | | ||
| |:---------------------:|:---------------------:|----------------------------------------------------------| | ||
| | v1.0.0 | v1.0-v1.1, v2.0, v3.0 | This package is incompatible with the RSK saml component | |
Contributor
There was a problem hiding this comment.
The note sounds like the rest of the versions are not compatible. I would put the note outside of the table
Contributor
Author
There was a problem hiding this comment.
The note is specifically in the row of the table with incompatible versions. How would moving it outside the table clarify that? I have adjusted the sentence to hopefully clarify the meaning, also added a note for the next row for additional clarification.
jhbritton-RSK
force-pushed
the
read-me/version-support-table
branch
from
13b20a2 to
a75b023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.