Full Rebuild June 2025: bump ros2-distro-mutex to 0.9.0 and build_number to 7 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
|
Thanks a lot for the effort on this @wep21 ! Given https://discord.com/channels/1082332781146800168/1309147278191235072/1370691325325742092 and what is discussed in ros2/rmw_zenoh#637 (comment), probably we want to make sure right before we merge this full rebuild that we upgrade to rwm_zenoh 0.2.4 to ensure on wire compatibility with the latest apt binary packages that will be released in June 2025. |
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
|
@traversaro Do you know how can I resolve this conflict? |
It seems that cartographer has a run dependency on a old version of gtest: and see also: https://conda-metadata-app.streamlit.app/?q=conda-forge%2Flinux64%2Fcartographer-2.0.0-lua54hacd5b8a_30.conda . However, gtest is not part of global pinning (as it is typically just a test dependency and not something that is actually used by the installed libraries), so perhaps we can just remove the run depednency of cartographer on gtest? Let me check. |
Indeed, it seems that the gtest run depedendecy is unused, see the log from https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1226606&view=logs&jobId=7b6f2c87-f3a7-5133-8d84-7c03a75d9dfc&j=7b6f2c87-f3a7-5133-8d84-7c03a75d9dfc&t=9eb77fd2-8ddd-5444-8fc0-71cb28dcb736 : |
traversaro
added a commit
to traversaro/cartographer-feedstock
that referenced
this pull request
May 25, 2025
As these are just test-time dependencies, see RoboStack/ros-jazzy#54 (comment)
5 tasks
|
The problem should be fixed by conda-forge/cartographer-feedstock#76 . However, the fact that |
|
There is a new conflict related to vtk and pcl. |
|
This will be fixed by conda-forge/pcl-feedstock#82 and ensuring that vtk is pinned to 9.4.2 and pcl 1.15.0 . |
|
In RoboStack we i believe we don’t read the package.xml - so while this would be the correct way, it needs a new upstream release to be picked up (i opened a PR) |
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
|
@traversaro @Tobias-Fischer osx-64 and windows ci reach its limit. Is it better to change rmw_zenoh version to 0.2.4 in snapshot? |
Tobias-Fischer
approved these changes
Jun 7, 2025
|
All looks good to me, thanks a lot! Happy to merge if @traversaro is happy. Re rmw_zenoh: I'm indifferent, totally up to you. |
It does not seem that ros2/rmw_zenoh#637 (comment) or ros/rosdistro#46307 saw a lot of updates, so it is possible that also accounting for sync time the actual upgrade to 0.2.4 will take some time (my estimate: some weeks, possible up to a month). As I just edited the PR to not be marked as draft, and to have a more descriptive title. We do not provide a lot of documentation to the users on the full rebuilds, so the PR are the implicit docs, so I think it is useful if full rebuilds PR provide some info in their title. |
traversaro
changed the title
|
I have just a little doubt on the zenoh version pinned in the conda_build_config.yaml, let me check a minute. |
|
Yes, I think it make sense to update the pinned zenoh version to 1.3.4 . In particular, the version used are rmw_zenoh 0.2.3 and 0.2.4 are: rmw_zenoh 0.2.3 :
rmw_zenoh 0.2.4 :
As the rmw_zenoh CMake code list a lot of bug fixes needed (see https://github.com/ros2/rmw_zenoh/blob/0.2.3/zenoh_cpp_vendor/CMakeLists.txt#L20-L39), I think it is a good idea to use a zenoh release from the v1.3 series. As the changelog between 1.3.2 and 1.3.4 is just a bug fixes (see https://github.com/eclipse-zenoh/zenoh-c/releases/tag/1.3.3, https://github.com/eclipse-zenoh/zenoh-c/releases/tag/1.3.4, https://github.com/eclipse-zenoh/zenoh/releases/tag/1.3.3, https://github.com/eclipse-zenoh/zenoh/releases/tag/1.3.4) I think it is good idea to just pin zenoh here to 1.3.4 . |
traversaro
changed the title
|
Sorry for the additional 6 hours of wait, but I think only rmw_zenoh uses zenoh, so the risk of regression is low. |
|
It would also be cool to use the rattler-build latest version that contains a fix for prefix-dev/rattler-build#1375 , but for that I more afraid of regression due to prefix-dev/rattler-build#1701, so perhaps it is easier to wait, even as the clobbering is annoying but we did not received any user issue report about it. |
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
|
@traversaro @Tobias-Fischer maybe ready again |
traversaro
approved these changes
Jun 8, 2025
|
Great, as @Tobias-Fischer already approved, I think we can merge once the CI are green or timeout. |
|
@traversaro Finally, merge is ready. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of major dependencies: