Skip to content

Commit 7ef2ff7

Browse files
authored
Repo revamp: remove react/roblox integration packages (#45)
* update tools * style * remove react and roblox packages * misc remaining cleanup * more cleanup
1 parent 7ed40aa commit 7ef2ff7

43 files changed

Lines changed: 45 additions & 1250 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.lute/.config.luau‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ return {
55
linterrors = true,
66
aliases = {
77
scripts = "../scripts",
8-
std = "~/.lute/typedefs/0.1.0/std",
8+
std = "~/.lute/typedefs/1.0.1/std",
99
},
1010
},
1111
}

‎.lute/analyze.luau‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
1-
local runStep = require("@scripts/processExecution").runStep
1+
const runStep = require("@scripts/processExecution").runStep
22

3-
runStep("Selene check", { "selene", "modules" })
4-
runStep("Style check", { "stylua", "-c", "modules" })
3+
const function getTargetPaths()
4+
return "./.lute", "./modules", "./scripts", "./src"
5+
end
6+
7+
runStep("Selene check", { "selene", getTargetPaths() })
8+
runStep("Style check", { "stylua", "-c", getTargetPaths() })
59
runStep(
610
"Type check",
711
{ "luau-lsp", "analyze", "--defs", "globalTypes.d.luau", "--sourcemap", "sourcemap.json", "modules" }

‎.lute/build.luau‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
1-
local runStep = require("@scripts/processExecution").runStep
1+
const runStep = require("@scripts/processExecution").runStep
22

33
runStep("Install packages", { "wally", "install" })
44
runStep("Generate sourcemap", { "rojo", "sourcemap", "test.project.json", "-o", "sourcemap.json" })
5-
6-
runStep("Export package types", { "wally-package-types", "--sourcemap", "sourcemap.json", "Packages" })
7-
runStep("Export dev package types", { "wally-package-types", "--sourcemap", "sourcemap.json", "DevPackages" })
85
runStep(
96
"Fetch types",
107
{ "curl", "-s", "-O", "https://raw.githubusercontent.com/JohnnyMorganz/luau-lsp/master/scripts/globalTypes.d.luau" }

‎.lute/tests.luau‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ runStep("Run tests", {
2121
"--script",
2222
"scripts/test.lua",
2323
"--lua.globals",
24-
"__DEV__=true,__ROACT_17_INLINE_ACT__=true,__ROACT_17_MOCK_SCHEDULER__=true",
24+
"__DEV__=true",
2525
"--verbose",
2626
}, { env = { ROBLOX_API_KEY = apiKey } })

‎.styluaignore‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,8 @@ The repository is a [Wally](https://wally.run/) workspace. Source code lives und
1818
modules/
1919
signals/ # Core reactive primitives
2020
signals-scheduler/ # Batch/flush micro-scheduler
21-
signals-react/ # React integration hooks
22-
signals-roblox/ # Roblox-specific bindings
2321
signals-experimental/ # Experimental utilities
2422
resources/ # Lifetime and scoping primitives
25-
resources-react/ # React hook for resources
2623
```
2724

2825
Please only make modifications in the directories above. You may notice there are duplicate config files for some of our tooling (e.g. foreman.toml vs foreman-internal.toml, rotriever.toml vs wally.toml, default/test.project.json vs default.rbxp) as well as some internal specific files (e.g. .lestrc). Repo maintainers use these internal specific files to run the same tests on different tooling. The `default.project.json` describes the published Wally package layout; `test.project.json` is the development place used for local testing and CI. If you want to add or modify any of the repo tooling or packages (e.g. updating foreman.toml or wally.toml), please open an issue and reach out to the maintainers for assistance.
@@ -42,8 +39,6 @@ Contributions should follow existing code styling. In support of this, we use th
4239

4340
```bash
4441
rojo sourcemap test.project.json -o sourcemap.json
45-
wally-package-types --sourcemap sourcemap.json Packages
46-
wally-package-types --sourcemap sourcemap.json DevPackages
4742
curl -sO https://raw.githubusercontent.com/JohnnyMorganz/luau-lsp/master/scripts/globalTypes.d.luau
4843
luau-lsp analyze --defs globalTypes.d.luau --sourcemap sourcemap.json modules
4944
```
@@ -103,8 +98,8 @@ rocale-cli run \
10398
- Create a new API key with write access to your experience for `luau-execution-sessions` and `universe-places`
10499
5. On your fork, add these secrets
105100
- `ROBLOX_API_KEY`
106-
- `TEST_PLACE_ID`
107-
- `TEST_UNIVERSE_ID`
101+
- `ROBLOX_PLACE_ID`
102+
- `ROBLOX_UNIVERSE_ID`
108103

109104

110105
## Pull Request Guidelines

‎default.project.json‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
"SignalsFlags": {
1212
"$path": "modules/signals-flags/src"
1313
},
14-
"SignalsReact": {
15-
"$path": "modules/signals-react/src"
16-
},
1714
"SignalsScheduler": {
1815
"$path": "modules/signals-scheduler/src"
1916
}

‎foreman-internal.toml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
[tools]
2-
lest = { source = "Roblox/lest", version = "=3.9.2" }
3-
rbx-aged-cli = { source = "Roblox/rbx-aged-tool", version = "=5.8.1" }
2+
lest = { source = "Roblox/lest", version = "=3.11.1" }
3+
rbx-aged-cli = { source = "Roblox/rbx-aged-tool", version = "=5.11.0" }
44
rocale-cli = { source = "Roblox/rocale-cli", version = "=0.1.2" }
55
rojo = { source = "Roblox/rojo-rbx-rojo", version = "=7.3.0" }
6-
rotrieve = { source = "Roblox/rotriever", version = "=0.5.21" }
7-
selene = { source = "Roblox/Kampfkarren-selene", version = "=0.29.0" }
6+
rotrieve = { source = "Roblox/rotriever", version = "=0.5.36" }
7+
selene = { source = "Roblox/Kampfkarren-selene", version = "=0.30.0" }
88
stylua = { source = "Roblox/JohnnyMorganz-StyLua", version = "=2.0.1" }

‎foreman.toml‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
[tools]
2-
luau-lsp = { source = "JohnnyMorganz/luau-lsp", version = "=1.53.3" }
3-
lute = { source = "luau-lang/lute", version = "=0.1.0-nightly.20260408" }
4-
rocale-cli = { source = "Roblox/rocale-cli", version = "=0.1.2" }
2+
luau-lsp = { source = "JohnnyMorganz/luau-lsp", version = "=1.69.0" }
3+
lute = { source = "luau-lang/lute", version = "=1.0.1-nightly.20260813" }
4+
rocale-cli = { source = "Roblox/rocale-cli", version = "=0.1.3" }
55
rojo = { source = "rojo-rbx/rojo", version = "=7.5.1" }
6-
selene = { source = "Kampfkarren/selene", version = "=0.29.0" }
7-
stylua = { source = "JohnnyMorganz/StyLua", version = "=2.0.1" }
6+
selene = { source = "Kampfkarren/selene", version = "=0.31.0" }
7+
stylua = { source = "JohnnyMorganz/StyLua", version = "=2.5.2" }
88
wally = { source = "UpliftGames/wally", version = "=0.3.2" }
9-
wally-package-types = { source = "JohnnyMorganz/wally-package-types", version = "=1.6.2" }

‎modules/resources-react/README.md‎

Lines changed: 0 additions & 84 deletions
This file was deleted.

0 commit comments

Comments
 (0)