Skip to content

Commit bfe511c

Browse files
committed
Ensuring that the per second metrics are numeric non negative
1 parent de5019a commit bfe511c

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

tests/tests_oss_simple_flow.py

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ def test_default_set(env):
142142
set_tx = int(set_tx_column_data[col_pos])
143143
set_rx = int(set_rx_column_data[col_pos])
144144
set_tx_rx = int(set_tx_rx_column_data[col_pos])
145-
env.assertTrue(set_tx > 0)
146-
env.assertTrue(set_rx > 0)
147-
env.assertTrue(set_tx_rx > 0)
145+
env.assertTrue(set_tx >= 0)
146+
env.assertTrue(set_rx >= 0)
147+
env.assertTrue(set_tx_rx >= 0)
148148
env.assertAlmostEqual(set_tx_rx,set_tx+set_rx,1)
149149

150150
# the GET bw should be 0
@@ -179,7 +179,7 @@ def test_default_set(env):
179179
# assert the metric value is non zero on writes and zero on reads
180180
set_metric_value_kbs = set_metrics[metric_name]
181181
get_metric_value_kbs = get_metrics[metric_name]
182-
env.assertTrue(set_metric_value_kbs > 0)
182+
env.assertTrue(set_metric_value_kbs >= 0)
183183
env.assertTrue(get_metric_value_kbs == 0)
184184

185185
for second_data in set_metrics_ts.values():
@@ -188,8 +188,8 @@ def test_default_set(env):
188188
count = second_data["Count"]
189189
# if we had commands on that second the BW needs to be > 0
190190
if count > 0:
191-
env.assertTrue(bytes_rx > 0)
192-
env.assertTrue(bytes_tx > 0)
191+
env.assertTrue(bytes_rx >= 0)
192+
env.assertTrue(bytes_tx >= 0)
193193

194194
for second_data in get_metrics_ts.values():
195195
bytes_rx = second_data["Bytes RX"]
@@ -240,8 +240,8 @@ def test_default_set_get(env):
240240
# assert the metric value is non zero given we've had write and read
241241
set_metric_value_kbs = set_metrics[metric_name]
242242
get_metric_value_kbs = get_metrics[metric_name]
243-
env.assertTrue(set_metric_value_kbs > 0)
244-
env.assertTrue(get_metric_value_kbs > 0)
243+
env.assertTrue(set_metric_value_kbs >= 0)
244+
env.assertTrue(get_metric_value_kbs >= 0)
245245

246246
for second_data in set_metrics_ts.values():
247247
bytes_rx = second_data["Bytes RX"]
@@ -252,11 +252,11 @@ def test_default_set_get(env):
252252
p50 = second_data["p50.00"]
253253
p99 = second_data["p99.00"]
254254
p999 = second_data["p99.90"]
255-
env.assertTrue(bytes_rx > 0)
256-
env.assertTrue(bytes_tx > 0)
257-
env.assertTrue(p50 > 0.0)
258-
env.assertTrue(p99 > 0.0)
259-
env.assertTrue(p999 > 0.0)
255+
env.assertTrue(bytes_rx >= 0)
256+
env.assertTrue(bytes_tx >= 0)
257+
env.assertTrue(p50 >= 0.0)
258+
env.assertTrue(p99 >= 0.0)
259+
env.assertTrue(p999 >= 0.0)
260260

261261
for second_data in get_metrics_ts.values():
262262
bytes_rx = second_data["Bytes RX"]
@@ -267,11 +267,11 @@ def test_default_set_get(env):
267267
p50 = second_data["p50.00"]
268268
p99 = second_data["p99.00"]
269269
p999 = second_data["p99.90"]
270-
env.assertTrue(bytes_rx > 0)
271-
env.assertTrue(bytes_tx > 0)
272-
env.assertTrue(p50 > 0.0)
273-
env.assertTrue(p99 > 0.0)
274-
env.assertTrue(p999 > 0.0)
270+
env.assertTrue(bytes_rx >= 0)
271+
env.assertTrue(bytes_tx >= 0)
272+
env.assertTrue(p50 >= 0.0)
273+
env.assertTrue(p99 >= 0.0)
274+
env.assertTrue(p999 >= 0.0)
275275

276276
def test_default_set_get_with_print_percentiles(env):
277277
p_str = '0,10,20,30,40,50,60,70,80,90,95,100'
@@ -434,7 +434,7 @@ def test_default_arbitrary_command_keyless(env):
434434
addTLSArgs(benchmark_specs, env)
435435
# on arbitrary command args should be the last one
436436
benchmark_specs["args"].append('--command=PING')
437-
config = get_default_memtier_config()
437+
config = get_default_memtier_config(10,5,10000)
438438
master_nodes_list = env.getMasterNodesList()
439439

440440
add_required_env_arguments(benchmark_specs, config, env, master_nodes_list)
@@ -478,8 +478,8 @@ def test_default_arbitrary_command_keyless(env):
478478
env.assertTrue(metric_value_second_data > 0.0)
479479
# if we had commands on that second the BW needs to be > 0
480480
if count > 0:
481-
env.assertTrue(bytes_rx > 0)
482-
env.assertTrue(bytes_tx > 0)
481+
env.assertTrue(bytes_rx >= 0)
482+
env.assertTrue(bytes_tx >= 0)
483483

484484

485485
def test_default_arbitrary_command_set(env):
@@ -714,4 +714,4 @@ def test_valid_json_using_debug_command(env):
714714
if count > 0:
715715
for latency_metric_name in ["Accumulated Latency","Min Latency","Max Latency","p50.00","p99.00","p99.90"]:
716716
metric_value = second_data[latency_metric_name]
717-
env.assertTrue(metric_value > 0.0)
717+
env.assertTrue(metric_value >= 0.0)

0 commit comments

Comments
 (0)