Skip to content

Duplicate reactions added when library included in libraries and seed #2979

Description

@sevyharris

Bug Description

I'm getting some duplicate reactions when I run an input file that has BurkeH2O2inArHe listed as both a seed and a library.

O(5)+H2(13)<=>H(14)+OH(15) is supposed to appear twice but appears 4x. I think there may be two other MultiArrhenius reactions in this example that also get incorrectly duplicated.

! Reaction index: Chemkin #2; RMG #2
! Library reaction: BurkeH2O2inArHe
O(5)+H2(13)<=>H(14)+OH(15)                          3.818000e+12 0.000     7.948
DUPLICATE
! Reaction index: Chemkin #3; RMG #2
! Library reaction: BurkeH2O2inArHe
O(5)+H2(13)<=>H(14)+OH(15)                          8.792000e+14 0.000     19.170
DUPLICATE

...

! Reaction index: Chemkin #42; RMG #39
! Library reaction: BurkeH2O2inArHe
O(5)+H2(13)<=>H(14)+OH(15)                          3.818000e+12 0.000     7.948
DUPLICATE
! Reaction index: Chemkin #43; RMG #39
! Library reaction: BurkeH2O2inArHe
O(5)+H2(13)<=>H(14)+OH(15)                          8.792000e+14 0.000     19.170
DUPLICATE



chem_annotated.inp.txt
species_dictionary.txt

How To Reproduce

Here's the input file that causes the duplicates: input.py.txt

Try python ~/rmg/RMG-Py/rmg.py input.py -t=00:00:02:00 to run for 2 minutes and produce a relatively small example mechanism

Then to fix the error you can remove BurkeH2O2inArHe from the libraries but keep it in the seed.

Expected Behavior

I would expect RMG to catch any duplicates before adding them, or at least produce an error if you're not supposed to include something as both a library and a seed. Or maybe have louder documentation about not doing this.

Installation Information

Describe your installation method and system information.

  • OS: Ubuntu 24.04.4 LTS
  • Installation method: source
  • RMG version information:
    • RMG-Py: 9901968
    • RMG-database: a956fac64a696b84b1183c617e07fc3c1b5ff6a6

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stalestale issue/PR as determined by actions bot

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions