Some code polishing.

Author: krulis-martin

app/V1Module/presenters/RegistrationPresenter.php

@@ -18,11 +18,9 @@
 use App\Model\Entity\Instance;
 use App\Model\Repository\Groups;
 use App\Model\Repository\Logins;
-use App\Model\Repository\ExternalLogins;
 use App\Model\Repository\Instances;
 use App\Model\View\UserViewFactory;
 use App\Security\AccessManager;
-use App\Helpers\ExternalLogin\ExternalServiceAuthenticator;
 use App\Helpers\EmailVerificationHelper;
 use App\Helpers\RegistrationConfig;
 use App\Helpers\InvitationHelper;
@@ -47,12 +45,6 @@ class RegistrationPresenter extends BasePresenter
      */
     public $logins;
 
-    /**
-     * @var ExternalLogins
-     * @inject
-     */
-    public $externalLogins;
-
     /**
      * @var AccessManager
      * @inject
@@ -71,12 +63,6 @@ class RegistrationPresenter extends BasePresenter
      */
     public $groups;
 
-    /**
-     * @var ExternalServiceAuthenticator
-     * @inject
-     */
-    public $externalServiceAuthenticator;
-
     /**
      * @var EmailVerificationHelper
      * @inject

app/V1Module/presenters/UsersPresenter.php

@@ -351,20 +351,20 @@ private function changeUserEmail(User $user, ?string $email)
      * Change first name and last name and check if user can change them.
      * @param User $user
      * @param null|string $titlesBefore
-     * @param null|string $firstname
-     * @param null|string $lastname
+     * @param null|string $firstName
+     * @param null|string $lastName
      * @param null|string $titlesAfter
      * @throws ForbiddenRequestException
      */
     private function changePersonalData(
         User $user,
         ?string $titlesBefore,
-        ?string $firstname,
-        ?string $lastname,
+        ?string $firstName,
+        ?string $lastName,
         ?string $titlesAfter
     ) {
         if (
-            ($titlesBefore !== null || $firstname !== null || $lastname !== null || $titlesAfter !== null) &&
+            ($titlesBefore !== null || $firstName !== null || $lastName !== null || $titlesAfter !== null) &&
             !$this->userAcl->canUpdatePersonalData($user)
         ) {
             throw new ForbiddenRequestException("You cannot update personal data");
@@ -374,12 +374,12 @@ private function changePersonalData(
             $user->setTitlesBeforeName(trim($titlesBefore));
         }
 
-        if ($firstname && trim($firstname)) {
-            $user->setFirstName(trim($firstname));
+        if ($firstName && trim($firstName)) {
+            $user->setFirstName(trim($firstName));
         }
 
-        if ($lastname && trim($lastname)) {
-            $user->setLastName(trim($lastname));
+        if ($lastName && trim($lastName)) {
+            $user->setLastName(trim($lastName));
         }
 
         if ($titlesAfter !== null) {