Skip to content

【BSP】 ADD C906 VIRT64 BSP SUPPORT #10374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2025
Merged

【BSP】 ADD C906 VIRT64 BSP SUPPORT #10374

merged 3 commits into from
Jun 22, 2025

Conversation

rcitach
Copy link
Contributor

@rcitach rcitach commented Jun 9, 2025

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the BSP label Jun 9, 2025
@supperthomas supperthomas added the BSP: new bsp board New added bsp, need sync action label Jun 9, 2025
Rbb666
Rbb666 reviewed Jun 10, 2025
View reviewed changes
@Rbb666 Rbb666 added the Arch: RISC-V BSP related with risc-v label Jun 10, 2025
@supperthomas
Copy link
Member

supperthomas commented Jun 10, 2025 •
edited
Loading

如果是新增bsp, 已经添加ci检查到https://github.com/RT-Thread/rt-thread/blob/master/.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@supperthomas
Copy link
Member

https://club.rt-thread.org/ask/article/a968b8e82fdc990b.html

@rcitach rcitach requested a review from supperthomas as a code owner June 11, 2025 10:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: workflow

Path: .github
Reviewers: supperthomas Rbb666 kurisaW

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json
  • .github/workflows/bsp_buildings.yml
  • .github/workflows/utest_auto_run.yml

📊 Current Review Status (Last Updated: 2025-06-22 02:17 UTC)

  • ⌛ Rbb666 Pending Review
  • ⌛ kurisaW Pending Review
  • ⌛ supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added the action github action yml imporve label Jun 11, 2025
@supperthomas
Copy link
Member

ci有问题

@rcitach
Copy link
Contributor Author

rcitach commented Jun 12, 2025

ci有问题

这个需要等后续工具链更新，在重新跑一次CI

@supperthomas
Copy link
Member

ci有问题

这个需要等后续工具链更新，在重新跑一次CI

/opt/Xuantie-900-gcc-linux-6.6.0-musl64-x86_64-V3.0.2/bin/riscv64-unknown-linux-musl-gcc: No such file or directory

@rcitach
Copy link
Contributor Author

rcitach commented Jun 12, 2025

ci有问题

这个需要等后续工具链更新，在重新跑一次CI

/opt/Xuantie-900-gcc-linux-6.6.0-musl64-x86_64-V3.0.2/bin/riscv64-unknown-linux-musl-gcc: No such file or directory

https://github.com/RT-Thread/toolchains-ci/releases/
最新的修改工具链已经提交了，还没更新

@supperthomas
Copy link
Member

image

把这个压缩包自己下下来看看，路径好像不对。

@supperthomas supperthomas requested a review from Rbb666 June 12, 2025 06:48
@rcitach
Copy link
Contributor Author

rcitach commented Jun 12, 2025

image

把这个压缩包自己下下来看看，路径好像不对。

https://github.com/RT-Thread/toolchains-ci/releases/
最新的修改工具链已经提交了，还没更新

@rcitach rcitach marked this pull request as draft June 12, 2025 06:50
@rcitach rcitach marked this pull request as ready for review June 13, 2025 10:14
@rcitach rcitach force-pushed the rcitach/c906 branch 2 times, most recently from 0a3c713 to 1818806 Compare June 16, 2025 05:37
@Rbb666
Copy link
Member

Rbb666 commented Jun 17, 2025

@rcitach utest_auto_run的ci麻烦也加一下吧：https://github.com/RT-Thread/rt-thread/blob/master/.github/workflows/utest_auto_run.yml

@kurisaW
Copy link
Member

kurisaW commented Jun 17, 2025

玄铁的这款bsp的qemu估计是定制版，原本的识别不到这个cpu

image

@rcitach
Copy link
Contributor Author

rcitach commented Jun 17, 2025

玄铁的这款bsp的qemu估计是定制版，原本的识别不到这个cpu

image

是的

@Rbb666 Rbb666 closed this Jun 22, 2025
@Rbb666 Rbb666 reopened this Jun 22, 2025
@Rbb666 Rbb666 merged commit 7178c93 into RT-Thread:master Jun 22, 2025
121 checks passed
@rcitach rcitach deleted the rcitach/c906 branch July 17, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supperthomas supperthomas supperthomas approved these changes

@Rbb666 Rbb666 Rbb666 approved these changes

Assignees
No one assigned
Labels
action github action yml imporve Arch: RISC-V BSP related with risc-v BSP: new bsp board New added bsp, need sync action BSP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcitach @CLAassistant @supperthomas @Rbb666 @kurisaW